Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2155183002: Revert "Delete the v8_target_cpu/v8_current_cpu hack in the GN build." (Closed)

Created:
4 years, 5 months ago by wuchengli
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Delete the v8_target_cpu/v8_current_cpu hack in the GN build." This reverts commit d3e00ac37e3722cc93d102164b23629e8cc6af31. ChromeOS would crash at boot and could not reach login screen with commit d3e00a. BUG=chromium:593461 TBR=dpranke@chromium.org TBR=machenbach@chromium.org Committed: https://crrev.com/9557ecb972e31f33470584e31ffbd602c767913a Cr-Commit-Position: refs/heads/master@{#405989}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/toolchain/gcc_toolchain.gni View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155183002/1
4 years, 5 months ago (2016-07-18 14:01:31 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 14:50:39 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 14:50:48 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9557ecb972e31f33470584e31ffbd602c767913a Cr-Commit-Position: refs/heads/master@{#405989}
4 years, 5 months ago (2016-07-18 14:54:41 UTC) #12
Dirk Pranke
4 years, 5 months ago (2016-07-18 19:21:55 UTC) #13
Message was sent while issue was closed.
lgtm, thanks for the revert.

Powered by Google App Engine
This is Rietveld 408576698