Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: build/toolchain/gcc_toolchain.gni

Issue 2155183002: Revert "Delete the v8_target_cpu/v8_current_cpu hack in the GN build." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/clang/clang.gni") 5 import("//build/config/clang/clang.gni")
6 import("//build/config/nacl/config.gni") 6 import("//build/config/nacl/config.gni")
7 import("//build/config/sanitizers/sanitizers.gni") 7 import("//build/config/sanitizers/sanitizers.gni")
8 import("//build/config/v8_target_cpu.gni") 8 import("//build/config/v8_target_cpu.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 import("//build/toolchain/goma.gni") 10 import("//build/toolchain/goma.gni")
(...skipping 457 matching lines...) Expand 10 before | Expand all | Expand 10 after
468 } 468 }
469 if (defined(invoker.use_sysroot)) { 469 if (defined(invoker.use_sysroot)) {
470 use_sysroot = invoker.use_sysroot 470 use_sysroot = invoker.use_sysroot
471 } 471 }
472 if (defined(invoker.v8_toolchain_cpu)) { 472 if (defined(invoker.v8_toolchain_cpu)) {
473 v8_current_cpu = invoker.v8_toolchain_cpu 473 v8_current_cpu = invoker.v8_toolchain_cpu
474 } else { 474 } else {
475 v8_current_cpu = current_cpu 475 v8_current_cpu = current_cpu
476 } 476 }
477 477
478 # TODO(crbug.com/625353) - Delete after v8 has been updated
479 # to only refer to v8_current_cpu. Until then, we need to make
480 # sure that v8_current_cpu always has the same value as v8_target_cpu,
481 # so that //build defines evaluate the way v8 is expecting them to.
482 v8_current_cpu = v8_target_cpu
483
478 # Disable sanitizers for non-default toolchains. 484 # Disable sanitizers for non-default toolchains.
479 is_asan = false 485 is_asan = false
480 is_cfi = false 486 is_cfi = false
481 is_lsan = false 487 is_lsan = false
482 is_msan = false 488 is_msan = false
483 is_syzyasan = false 489 is_syzyasan = false
484 is_tsan = false 490 is_tsan = false
485 is_ubsan = false 491 is_ubsan = false
486 is_ubsan_null = false 492 is_ubsan_null = false
487 is_ubsan_no_recover = false 493 is_ubsan_no_recover = false
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
537 "toolchain_os", 543 "toolchain_os",
538 "use_gold", 544 "use_gold",
539 "v8_toolchain_cpu", 545 "v8_toolchain_cpu",
540 ]) 546 ])
541 547
542 if (defined(invoker.use_debug_fission)) { 548 if (defined(invoker.use_debug_fission)) {
543 use_debug_fission = invoker.use_debug_fission 549 use_debug_fission = invoker.use_debug_fission
544 } 550 }
545 } 551 }
546 } 552 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698