Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1235)

Issue 2155143003: Remove clock resolution page load histograms. (Closed)

Created:
4 years, 5 months ago by Bryan McQuade
Modified:
4 years, 5 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove clock resolution page load histograms. These were temporary metrics intended to understand whether high/low resolution clocks adversely impact page load metrics. After collecting a few months of data it was determined that clock resolution doesn't adversely impact our metrics, and it that these histograms were no longer needed. BUG=394757 Committed: https://crrev.com/4843d98517bd37e5940cd04627c6cfd2ac774d11 Cr-Commit-Position: refs/heads/master@{#406143}

Patch Set 1 #

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Bryan McQuade
PTAL
4 years, 5 months ago (2016-07-18 14:58:45 UTC) #8
Charlie Harrison
lgtm
4 years, 5 months ago (2016-07-18 15:00:14 UTC) #9
Ilya Sherman
LGTM. Thanks for the cleanup! =)
4 years, 5 months ago (2016-07-18 22:55:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155143003/20001
4 years, 5 months ago (2016-07-18 23:05:21 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-18 23:42:29 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 23:45:38 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4843d98517bd37e5940cd04627c6cfd2ac774d11
Cr-Commit-Position: refs/heads/master@{#406143}

Powered by Google App Engine
This is Rietveld 408576698