Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2408)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

Issue 2155143003: Remove clock resolution page load histograms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
index d5dd2d533beb0c8e5705863a0013b96f43937b9e..d19a181bed5fb855ef3a786c20bb7a92e06388e0 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
@@ -198,11 +198,6 @@ const char kHistogramLoadTypeParseStartForwardBack[] =
const char kHistogramLoadTypeParseStartNewNavigation[] =
"PageLoad.ParseTiming.NavigationToParseStart.LoadType.NewNavigation";
-const char kHistogramFirstContentfulPaintHigh[] =
- "PageLoad.Timing2.NavigationToFirstContentfulPaint.HighResolutionClock";
-const char kHistogramFirstContentfulPaintLow[] =
- "PageLoad.Timing2.NavigationToFirstContentfulPaint.LowResolutionClock";
-
const char kHistogramFirstBackground[] =
"PageLoad.Timing2.NavigationToFirstBackground";
const char kHistogramFirstForeground[] =
@@ -582,15 +577,6 @@ void CorePageLoadMetricsObserver::RecordTimingHistograms(
timing.first_contentful_paint, info)) {
PAGE_LOAD_HISTOGRAM(internal::kHistogramFirstContentfulPaint,
timing.first_contentful_paint.value());
- // Bucket these histograms into high/low resolution clock systems. This
- // might point us to directions that will de-noise some UMA.
- if (base::TimeTicks::IsHighResolution()) {
- PAGE_LOAD_HISTOGRAM(internal::kHistogramFirstContentfulPaintHigh,
- timing.first_contentful_paint.value());
- } else {
- PAGE_LOAD_HISTOGRAM(internal::kHistogramFirstContentfulPaintLow,
- timing.first_contentful_paint.value());
- }
PAGE_LOAD_HISTOGRAM(
internal::kHistogramParseStartToFirstContentfulPaint,
timing.first_contentful_paint.value() - timing.parse_start.value());
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698