Add infraenv, setup creds and tee for Kitchen.

Add infraenv, setup creds and tee for Kitchen.

Add "infra/libs/infraenv", a package that exposes Infra-specific
envrionment functionality. Currently it exports the LogDog service
account credential path.

Leverage "infraenv" in Kitchen to load the LogDog service account
credential for non-GCE instance systems; GCE systems will use their
native metadata token to authenticate to LogDog.

Enable STDOUT/STDERR teeing in Kitchen/LogDog integration so we can run
it in a hybrid mode, compatible both with Milo/Swarming and Milo/LogDog.

BUG=chromium:628321
TEST=None

Committed: https://chromium.googlesource.com/infra/infra/+/51da592b407fc30601445f532855205309403910

[dnj (Google), 2016-07-16 00:00:06]

dnj@google.com changed reviewers:
+ dnj@google.com, nodir@chromium.org

[dnj (Google), 2016-07-16 00:00:07]

PTAL

[nodir, 2016-07-16 00:38:55]

lgtm

https://codereview.chromium.org/2154953002/diff/60001/go/src/infra/libs/infra...
File go/src/infra/libs/infraenv/doc.go (right):

https://codereview.chromium.org/2154953002/diff/60001/go/src/infra/libs/infra...
go/src/infra/libs/infraenv/doc.go:6: // Infrastructure-specific bot parameters.
if this is about bot, maybe the package should be called botenv

https://codereview.chromium.org/2154953002/diff/60001/go/src/infra/libs/infra...
File go/src/infra/libs/infraenv/paths_posix.go (right):

https://codereview.chromium.org/2154953002/diff/60001/go/src/infra/libs/infra...
go/src/infra/libs/infraenv/paths_posix.go:5: // +build darwin dragonfly freebsd
linux netbsd openbsd
how about
// +build !windows
?

[dnj (Google), 2016-07-16 00:49:39]

https://codereview.chromium.org/2154953002/diff/60001/go/src/infra/libs/infra...
File go/src/infra/libs/infraenv/doc.go (right):

https://codereview.chromium.org/2154953002/diff/60001/go/src/infra/libs/infra...
go/src/infra/libs/infraenv/doc.go:6: // Infrastructure-specific bot parameters.
On 2016/07/16 00:38:55, nodir wrote:
> if this is about bot, maybe the package should be called botenv

So far it's about bot, but I think it's a good idea to consolidate all of our
Infra irregularities here, so I anticipate this expanding.

https://codereview.chromium.org/2154953002/diff/60001/go/src/infra/libs/infra...
File go/src/infra/libs/infraenv/paths_posix.go (right):

https://codereview.chromium.org/2154953002/diff/60001/go/src/infra/libs/infra...
go/src/infra/libs/infraenv/paths_posix.go:5: // +build darwin dragonfly freebsd
linux netbsd openbsd
On 2016/07/16 00:38:55, nodir wrote:
> how about
> // +build !windows
> ?

I like calling out OSes b/c this means if we ever try to build it for another,
it will fail rather than build unintentionally.

[dnj (Google), 2016-07-16 00:49:43]

The CQ bit was checked by dnj@google.com

[commit-bot: I haz the power, 2016-07-16 00:49:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-16 00:57:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-16 00:57:18]

Try jobs failed on following builders:
  Infra Mac Tester on master.tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Infra%20Mac%20Tester/bu...)

[nodir, 2016-07-16 00:59:32]

https://codereview.chromium.org/2154953002/diff/60001/go/src/infra/libs/infra...
File go/src/infra/libs/infraenv/paths_posix.go (right):

https://codereview.chromium.org/2154953002/diff/60001/go/src/infra/libs/infra...
go/src/infra/libs/infraenv/paths_posix.go:5: // +build darwin dragonfly freebsd
linux netbsd openbsd
On 2016/07/16 00:49:39, dnj (Google) wrote:
> On 2016/07/16 00:38:55, nodir wrote:
> > how about
> > // +build !windows
> > ?
> 
> I like calling out OSes b/c this means if we ever try to build it for another,
> it will fail rather than build unintentionally.

i thought only windows is not posix-compliant

[dnj (Google), 2016-07-16 01:06:19]

https://codereview.chromium.org/2154953002/diff/60001/go/src/infra/libs/infra...
File go/src/infra/libs/infraenv/paths_posix.go (right):

https://codereview.chromium.org/2154953002/diff/60001/go/src/infra/libs/infra...
go/src/infra/libs/infraenv/paths_posix.go:5: // +build darwin dragonfly freebsd
linux netbsd openbsd
On 2016/07/16 00:59:32, nodir wrote:
> On 2016/07/16 00:49:39, dnj (Google) wrote:
> > On 2016/07/16 00:38:55, nodir wrote:
> > > how about
> > > // +build !windows
> > > ?
> > 
> > I like calling out OSes b/c this means if we ever try to build it for
another,
> > it will fail rather than build unintentionally.
> 
> i thought only windows is not posix-compliant

It's less about compliance and more about which platforms we explicitly have
credentials paths deployed on.

[dnj (Google), 2016-07-16 01:06:23]

The CQ bit was checked by dnj@google.com

[dnj (Google), 2016-07-16 01:06:23]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/2154953002/#ps80001
(title: "Add coverage file, restrict platforms to actual Infra platforms.")

[commit-bot: I haz the power, 2016-07-16 01:06:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 10:03:35]

Description was changed from

==========
Add infraenv, setup creds and tee for Kitchen.

Add "infra/libs/infraenv", a package that exposes Infra-specific
envrionment functionality. Currently it exports the LogDog service
account credential path.

Leverage "infraenv" in Kitchen to load the LogDog service account
credential for non-GCE instance systems; GCE systems will use their
native metadata token to authenticate to LogDog.

Enable STDOUT/STDERR teeing in Kitchen/LogDog integration so we can run
it in a hybrid mode, compatible both with Milo/Swarming and Milo/LogDog.

BUG=chromium:628321
TEST=None
==========

to

==========
Add infraenv, setup creds and tee for Kitchen.

Add "infra/libs/infraenv", a package that exposes Infra-specific
envrionment functionality. Currently it exports the LogDog service
account credential path.

Leverage "infraenv" in Kitchen to load the LogDog service account
credential for non-GCE instance systems; GCE systems will use their
native metadata token to authenticate to LogDog.

Enable STDOUT/STDERR teeing in Kitchen/LogDog integration so we can run
it in a hybrid mode, compatible both with Milo/Swarming and Milo/LogDog.

BUG=chromium:628321
TEST=None

Committed:
https://chromium.googlesource.com/infra/infra/+/51da592b407fc30601445f5328552...
==========

[commit-bot: I haz the power, 2016-07-18 10:03:37]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/infra/infra/+/51da592b407fc30601445f5328552...

[commit-bot: I haz the power, 2016-07-18 10:03:38]

CQ bit was unchecked.