go/src/infra/libs/infraenv/paths_posix.go - Issue 2154953002: Add infraenv, setup creds and tee for Kitchen.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: go/src/infra/libs/infraenv/paths_posix.go

Issue 2154953002: Add infraenv, setup creds and tee for Kitchen. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Handle both host string and host URL. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // +build darwin dragonfly freebsd linux netbsd openbsd
	nodir 2016/07/16 00:38:55 how about // +build !windows ? how about // +build !windows ? dnj (Google) 2016/07/16 00:49:39 I like calling out OSes b/c this means if we ever Show quoted text On 2016/07/16 00:38:55, nodir wrote: > how about > // +build !windows > ? I like calling out OSes b/c this means if we ever try to build it for another, it will fail rather than build unintentionally. nodir 2016/07/16 00:59:32 i thought only windows is not posix-compliant Show quoted text On 2016/07/16 00:49:39, dnj (Google) wrote: > On 2016/07/16 00:38:55, nodir wrote: > > how about > > // +build !windows > > ? > > I like calling out OSes b/c this means if we ever try to build it for another, > it will fail rather than build unintentionally. i thought only windows is not posix-compliant dnj (Google) 2016/07/16 01:06:18 It's less about compliance and more about which pl Show quoted text On 2016/07/16 00:59:32, nodir wrote: > On 2016/07/16 00:49:39, dnj (Google) wrote: > > On 2016/07/16 00:38:55, nodir wrote: > > > how about > > > // +build !windows > > > ? > > > > I like calling out OSes b/c this means if we ever try to build it for another, > > it will fail rather than build unintentionally. > > i thought only windows is not posix-compliant It's less about compliance and more about which platforms we explicitly have credentials paths deployed on.
	6

	7 package infraenv

	8

	9 var (

	10 // Paths on the system where credentials are stored.

	11 //

	12 // This path is provisioned by Puppet.

	13 systemCredentialDirs = []string{

	14 "/creds/service_accounts",

	15 }

	16 )

OLD	NEW

« go/src/infra/libs/infraenv/doc.go ('K') | « go/src/infra/libs/infraenv/doc.go ('k') | go/src/infra/libs/infraenv/paths_windows.go » ('j') | no next file with comments »