Allow idle/suspend with 3+ monitors attached

Allow idle/suspend with 3+ monitors attached

On Samus it is possible to connect 2 external displays and on other
chromebooks it is possible to connect 2 DisplayLink devices to have
more than 2 monitors. In such cases turning off displays causes the
display configuration to fail and present a "Dear monitor..." message
even though it is possible to turn off these displays.

BUG=627795
TEST=display_unittests and ran on Samus with 2 DisplayLink devices attached.

Committed: https://crrev.com/310889b982ca44844dbb79b409b874f3267c58fe
Cr-Commit-Position: refs/heads/master@{#406555}

[dnicoara, 2016-07-15 18:46:20]

The CQ bit was checked by dnicoara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 18:46:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dnicoara, 2016-07-15 18:47:00]

dnicoara@chromium.org changed reviewers:
+ oshima@chromium.org

[dnicoara, 2016-07-15 18:47:00]

PTAL

[commit-bot: I haz the power, 2016-07-15 20:00:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 20:00:16]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-07-15 23:58:15]

lgtm

https://codereview.chromium.org/2152303002/diff/1/ui/display/chromeos/display...
File ui/display/chromeos/display_configurator.cc (right):

https://codereview.chromium.org/2152303002/diff/1/ui/display/chromeos/display...
ui/display/chromeos/display_configurator.cc:305: }
can you add comment that in docked mode, we may get multi_extended with 2
displays?

[dnicoara, 2016-07-18 14:19:02]

https://codereview.chromium.org/2152303002/diff/1/ui/display/chromeos/display...
File ui/display/chromeos/display_configurator.cc (right):

https://codereview.chromium.org/2152303002/diff/1/ui/display/chromeos/display...
ui/display/chromeos/display_configurator.cc:305: }
On 2016/07/15 23:58:15, oshima wrote:
> can you add comment that in docked mode, we may get multi_extended with 2
> displays?

Actually the state would be MULTIPLE_DISPLAY_STATE_DUAL_EXTENDED in that case.
We do a similar optimization for docked mode with one external display (and in
that case the state is MULTIPLE_DISPLAY_STATE_SINGLE). (See
UpdateDisplayConfigurationTask::ChooseDisplayState() for the details.)

I double checked that docked mode with 2 external displays works as expected.

I've added a comment to explain this. I'll wait for your ack before committing
just in case you think we should do more checks.

[dnicoara, 2016-07-19 16:08:51]

The CQ bit was checked by dnicoara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 16:09:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 17:06:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 17:06:17]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-07-20 14:37:54]

slgtm

https://codereview.chromium.org/2152303002/diff/20001/ui/display/chromeos/dis...
File ui/display/chromeos/display_configurator.cc (right):

https://codereview.chromium.org/2152303002/diff/20001/ui/display/chromeos/dis...
ui/display/chromeos/display_configurator.cc:301: // external displays turned on.
ack. thank you for clarificatin.

[dnicoara, 2016-07-20 14:42:05]

The CQ bit was checked by dnicoara@chromium.org

[dnicoara, 2016-07-20 14:42:06]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2152303002/#ps20001
(title: ".")

[commit-bot: I haz the power, 2016-07-20 14:42:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 14:48:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-20 14:48:52]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-20 14:52:32]

Description was changed from

==========
Allow idle/suspend with 3+ monitors attached

On Samus it is possible to connect 2 external displays and on other
chromebooks it is possible to connect 2 DisplayLink devices to have
more than 2 monitors. In such cases turning off displays causes the
display configuration to fail and present a "Dear monitor..." message
even though it is possible to turn off these displays.

BUG=627795
TEST=display_unittests and ran on Samus with 2 DisplayLink devices attached.
==========

to

==========
Allow idle/suspend with 3+ monitors attached

On Samus it is possible to connect 2 external displays and on other
chromebooks it is possible to connect 2 DisplayLink devices to have
more than 2 monitors. In such cases turning off displays causes the
display configuration to fail and present a "Dear monitor..." message
even though it is possible to turn off these displays.

BUG=627795
TEST=display_unittests and ran on Samus with 2 DisplayLink devices attached.

Committed: https://crrev.com/310889b982ca44844dbb79b409b874f3267c58fe
Cr-Commit-Position: refs/heads/master@{#406555}
==========

[commit-bot: I haz the power, 2016-07-20 14:52:33]

Patchset 2 (id:??) landed as
https://crrev.com/310889b982ca44844dbb79b409b874f3267c58fe
Cr-Commit-Position: refs/heads/master@{#406555}