Add check for GmsCore before showing AccountSigninActivity.

Add check for GmsCore before showing AccountSigninActivity.

BUG=626702, 603020
Committed: https://crrev.com/a5e4f142152e01198c422b9fd5d9b357f76179cd
Cr-Commit-Position: refs/heads/master@{#408398}

[PEConn, 2016-07-15 09:24:38]

peconn@chromium.org changed reviewers:
+ bauerb@chromium.org, gogerald@chromium.org

[PEConn, 2016-07-15 09:24:38]

PTAL.

Some of the signin points (for example through Settings, Recent Tabs and
Bookmarks) pass an Activity, however some do not (through the Cards UI signin
prompt). It seemed quite far reaching to attempt to modify all the signin points
so that they provided an Activity (and didn't have to cast), so do you think
this is an acceptable solution?

[gogerald1, 2016-07-15 15:11:02]

https://codereview.chromium.org/2154733002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java
(right):

https://codereview.chromium.org/2154733002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java:58:
UserRecoverableErrorHandler errorHandler = context instanceof Activity
It seems we will miss FRE which is a very important access point.

how about do it in AccountSigninView,
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...

and rename getFragmentManager in delegate to getActivity if do not want to cast?

[PEConn, 2016-07-15 15:39:52]

https://codereview.chromium.org/2154733002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java
(right):

https://codereview.chromium.org/2154733002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java:58:
UserRecoverableErrorHandler errorHandler = context instanceof Activity
On 2016/07/15 15:11:01, gogerald1 wrote:
> It seems we will miss FRE which is a very important access point.
> 
> how about do it in AccountSigninView,
>
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...
> 
> and rename getFragmentManager in delegate to getActivity if do not want to
cast?

Done.

[Bernhard Bauer, 2016-07-18 09:19:11]

lgtm

[gogerald1, 2016-07-18 14:21:53]

lgtm

[PEConn, 2016-07-18 15:30:18]

The CQ bit was checked by peconn@chromium.org

[commit-bot: I haz the power, 2016-07-18 15:30:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 15:51:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 15:51:22]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[PEConn, 2016-07-19 16:39:29]

The CQ bit was checked by peconn@chromium.org

[PEConn, 2016-07-19 16:39:30]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
gogerald@chromium.org
Link to the patchset: https://codereview.chromium.org/2154733002/#ps40001
(title: "Merge.")

[commit-bot: I haz the power, 2016-07-19 16:39:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 18:00:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 18:00:32]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[PEConn, 2016-07-28 14:54:43]

The CQ bit was checked by peconn@chromium.org

[PEConn, 2016-07-28 14:54:44]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
gogerald@chromium.org
Link to the patchset: https://codereview.chromium.org/2154733002/#ps60001
(title: "Restrict test to devices with up to date GMSCore.")

[commit-bot: I haz the power, 2016-07-28 14:54:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 15:40:45]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-28 15:44:04]

Description was changed from

==========
Add check for GmsCore before showing AccountSigninActivity.

BUG=626702, 603020
==========

to

==========
Add check for GmsCore before showing AccountSigninActivity.

BUG=626702, 603020

Committed: https://crrev.com/a5e4f142152e01198c422b9fd5d9b357f76179cd
Cr-Commit-Position: refs/heads/master@{#408398}
==========

[commit-bot: I haz the power, 2016-07-28 15:44:05]

Patchset 4 (id:??) landed as
https://crrev.com/a5e4f142152e01198c422b9fd5d9b357f76179cd
Cr-Commit-Position: refs/heads/master@{#408398}