chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java - Issue 2154733002: Add check for GmsCore before showing AccountSigninActivity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java

Issue 2154733002: Add check for GmsCore before showing AccountSigninActivity. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Restrict test to devices with up to date GMSCore. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java

index 6b152726f5c0bd58ca91e4528753eaa65753c2f7..23c15b0c13d9e4dc7492d89b2b03459ea3183589 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java

@@ -4,6 +4,7 @@

package org.chromium.chrome.browser.signin;

+import android.app.Activity;

import android.content.Context;

import android.content.Intent;

import android.os.Bundle;

@@ -193,4 +194,10 @@ public class AccountSigninActivity extends AppCompatActivity

assert false : "Invalid access point.";

}

+ // AccountSigninView.Delegate implementation.

+ @Override

+ public Activity getActivity() {

+ return this;

+ }

}

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java » ('j') | no next file with comments »