Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2154703002: MIPS64: Fix 32bit right shift operators (Closed)

Created:
4 years, 5 months ago by Marija Antic
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix 32bit right shift operators Add sign extension for Mips64Shr and Mips64Sar operators. BUG= Committed: https://crrev.com/24d432cb8253eac55cb3649144809af3d43e634b Cr-Commit-Position: refs/heads/master@{#37943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
akos.palfi.imgtec
LGTM
4 years, 5 months ago (2016-07-21 11:06:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154703002/1
4 years, 5 months ago (2016-07-21 11:35:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 11:36:37 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 11:39:28 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24d432cb8253eac55cb3649144809af3d43e634b
Cr-Commit-Position: refs/heads/master@{#37943}

Powered by Google App Engine
This is Rietveld 408576698