Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1566)

Issue 2154663002: service worker: Relax the BadMessageReceived call in OnSetHostedVersionId (Closed)

Created:
4 years, 5 months ago by falken
Modified:
4 years, 5 months ago
Reviewers:
nhiroki, dcheng
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, mlamouri+watch-content_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

service worker: Relax the BadMessageReceived call in OnSetHostedVersionId The message may be for an embedded worker that had been detached. BUG=625042 Committed: https://crrev.com/1dd05b7262de80415eb0d106a0ff0a471d675aad Cr-Commit-Position: refs/heads/master@{#405748}

Patch Set 1 #

Patch Set 2 : patch #

Total comments: 2

Patch Set 3 : newl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -17 lines) Patch
M content/browser/service_worker/service_worker_dispatcher_host.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host_unittest.cc View 2 chunks +38 lines, -5 lines 0 comments Download
M content/child/service_worker/service_worker_network_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/service_worker/service_worker_network_provider.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/common/service_worker/service_worker_messages.h View 1 chunk +7 lines, -5 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
falken
ptal
4 years, 5 months ago (2016-07-15 06:46:20 UTC) #4
nhiroki
lgtm
4 years, 5 months ago (2016-07-15 07:44:56 UTC) #6
falken
dcheng: Can you review messages?
4 years, 5 months ago (2016-07-15 07:53:05 UTC) #8
dcheng
LGTM https://codereview.chromium.org/2154663002/diff/20001/content/browser/service_worker/service_worker_dispatcher_host.cc File content/browser/service_worker/service_worker_dispatcher_host.cc (right): https://codereview.chromium.org/2154663002/diff/20001/content/browser/service_worker/service_worker_dispatcher_host.cc#newcode886 content/browser/service_worker/service_worker_dispatcher_host.cc:886: // If the version has a different embedded ...
4 years, 5 months ago (2016-07-15 09:25:46 UTC) #11
falken
https://codereview.chromium.org/2154663002/diff/20001/content/browser/service_worker/service_worker_dispatcher_host.cc File content/browser/service_worker/service_worker_dispatcher_host.cc (right): https://codereview.chromium.org/2154663002/diff/20001/content/browser/service_worker/service_worker_dispatcher_host.cc#newcode886 content/browser/service_worker/service_worker_dispatcher_host.cc:886: // If the version has a different embedded worker, ...
4 years, 5 months ago (2016-07-15 11:30:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154663002/40001
4 years, 5 months ago (2016-07-15 11:31:33 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-15 13:07:07 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 13:09:04 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1dd05b7262de80415eb0d106a0ff0a471d675aad
Cr-Commit-Position: refs/heads/master@{#405748}

Powered by Google App Engine
This is Rietveld 408576698