content/common/service_worker/service_worker_messages.h - Issue 2154663002: service worker: Relax the BadMessageReceived call in OnSetHostedVersionId

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/service_worker/service_worker_messages.h

Issue 2154663002: service worker: Relax the BadMessageReceived call in OnSetHostedVersionId (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: newl Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/service_worker/service_worker_network_provider.cc ('k') | content/renderer/service_worker/service_worker_context_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/service_worker/service_worker_messages.h

diff --git a/content/common/service_worker/service_worker_messages.h b/content/common/service_worker/service_worker_messages.h

index 6fec69cdaf9a6d60c19eade88a7b09d1fd2e7846..6e8c3fe73760ac141d991e723cc8355cb9bfbe35 100644

--- a/content/common/service_worker/service_worker_messages.h

+++ b/content/common/service_worker/service_worker_messages.h

@@ -244,12 +244,14 @@ IPC_MESSAGE_CONTROL1(ServiceWorkerHostMsg_DecrementRegistrationRefCount,

IPC_MESSAGE_CONTROL1(ServiceWorkerHostMsg_TerminateWorker,

int /* handle_id */)

-// Informs the browser that |provider_id| is associated

-// with a service worker script running context and

-// |version_id| identifies which ServiceWorkerVersion.

-IPC_MESSAGE_CONTROL2(ServiceWorkerHostMsg_SetVersionId,

+// Informs the browser that a service worker is starting up in a provider.

+// |provider_id| identifies the ServiceWorkerProviderHost hosting the service

+// worker. |version_id| identifies the ServiceWorkerVersion and

+// |embedded_worker_id| identifies the EmbeddedWorkerInstance.

+IPC_MESSAGE_CONTROL3(ServiceWorkerHostMsg_SetVersionId,

int /* provider_id */,

- int64_t /* version_id */)

+ int64_t /* version_id */,

+ int /* embedded_worker_id */)

// Informs the browser that event handling has finished.

// Routed to the target ServiceWorkerVersion.