third_party/WebKit/Source/core/layout/LayoutBlock.cpp - Issue 2154593003: [css-grid] Fix indefinite height detection

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 2154593003: [css-grid] Fix indefinite height detection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix fast/table/003.html test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlock.h ('k') | third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutBox.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * (C) 2007 David Smith (catfish.man@gmail.com)	4 * (C) 2007 David Smith (catfish.man@gmail.com)

5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.	5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.

6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.	6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.

7 *	7 *

8 * This library is free software; you can redistribute it and/or	8 * This library is free software; you can redistribute it and/or

9 * modify it under the terms of the GNU Library General Public	9 * modify it under the terms of the GNU Library General Public

10 * License as published by the Free Software Foundation; either	10 * License as published by the Free Software Foundation; either

(...skipping 1854 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1865 TrackedLayoutBoxListHashSet::const_iterator end = positionedDescendantSe t->end();	1865 TrackedLayoutBoxListHashSet::const_iterator end = positionedDescendantSe t->end();

1866 for (TrackedLayoutBoxListHashSet::const_iterator it = positionedDescenda ntSet->begin(); it != end; ++it) {	1866 for (TrackedLayoutBoxListHashSet::const_iterator it = positionedDescenda ntSet->begin(); it != end; ++it) {

1867 LayoutBox* currBox = *it;	1867 LayoutBox* currBox = *it;

1868 ASSERT(!currBox->needsLayout());	1868 ASSERT(!currBox->needsLayout());

1869 }	1869 }

1870 }	1870 }

1871 }	1871 }

1872	1872

1873 #endif	1873 #endif

1874	1874

	1875 bool LayoutBlock::hasDefiniteLogicalHeight() const

	1876 {

	1877 return LayoutBox::availableLogicalHeightForPercentageComputation(this, false , scrollsOverflowY()) != LayoutUnit(-1);
	svillar 2016/07/18 08:43:30 This is one of the reasons why bools are normally This is one of the reasons why bools are normally not used for APIs, this false here is meaningless, it is impossible to know what it means unless I check the signature of the method.
	1878 }

	1879

1875 } // namespace blink	1880 } // namespace blink

OLD	NEW