Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Issue 2154493002: FrameTestHelpers: support Settings-parameterized tests. (Closed)

Created:
4 years, 5 months ago by szager1
Modified:
4 years, 5 months ago
Reviewers:
skobes
CC:
chromium-reviews, blink-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src@rls-enable
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

FrameTestHelpers: support Settings-parameterized tests. This consolidates the mechanism for running unit tests with and without root layer scrolling enabled. The same mechanism can be used to parameterize anything in WebSettings. BUG=490942 R=skobes@chromium.org Committed: https://crrev.com/c96d69ca9efd5966d4e6d26f70f3ca1316771a28 Cr-Commit-Position: refs/heads/master@{#405626}

Patch Set 1 #

Patch Set 2 : Elminate unnecessary #include. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -46 lines) Patch
M third_party/WebKit/Source/web/tests/FrameTestHelpers.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/VisualViewportTest.cpp View 2 chunks +3 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 3 chunks +9 lines, -33 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
szager1
4 years, 5 months ago (2016-07-14 21:25:15 UTC) #1
skobes
lgtm
4 years, 5 months ago (2016-07-14 21:44:21 UTC) #2
szager1
Elminate unnecessary #include.
4 years, 5 months ago (2016-07-14 22:10:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154493002/20001
4 years, 5 months ago (2016-07-14 22:11:28 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-14 23:28:05 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 23:28:09 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 23:29:20 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c96d69ca9efd5966d4e6d26f70f3ca1316771a28
Cr-Commit-Position: refs/heads/master@{#405626}

Powered by Google App Engine
This is Rietveld 408576698