third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp - Issue 2154493002: FrameTestHelpers: support Settings-parameterized tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp

Issue 2154493002: FrameTestHelpers: support Settings-parameterized tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@rls-enable

Patch Set: Elminate unnecessary #include. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/tests/FrameTestHelpers.h ('k') | third_party/WebKit/Source/web/tests/VisualViewportTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp

diff --git a/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp b/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp

index 46cde927488c57ec69d058a4c0edbf76829d3672..6f436c2a7c87debf4304612accfa46b148a9d50f 100644

--- a/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp

+++ b/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp

@@ -192,6 +192,15 @@ WebRemoteFrame* createRemoteChild(WebRemoteFrame* parent, WebRemoteFrameClient*

return parent->createRemoteChild(WebTreeScopeType::Document, name, nameToUniqueName(name), WebSandboxFlags::None, client, nullptr);

}

+void DefaultSettingOverride(WebSettings*)

+void RootLayerScrollsSettingOverride(WebSettings *settings)

+ settings->setRootLayerScrolls(true);

WebViewHelper::WebViewHelper(SettingOverrider* settingOverrider)

: m_webView(nullptr)

, m_settingOverrider(settingOverrider)