Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 2154363002: Move blimp switches to core (Closed)

Created:
4 years, 5 months ago by nyquist
Modified:
4 years, 5 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move blimp switches to core Currently the command line switches for blimp are in the app directory, but the code that will be using it will need to live in //blimp/client/core. This means that the switches should be made available to that code. It is not moved to the public directory because for now it should not be necessary for embedders to use them, and we should aim for the configurations there to be made available as real runtime APIs instead. BUG=611097 Committed: https://crrev.com/3f0f0534e9be73b50afde189218160cf45648884 Cr-Commit-Position: refs/heads/master@{#406100}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -110 lines) Patch
M blimp/client/BUILD.gn View 5 chunks +3 lines, -11 lines 0 comments Download
D blimp/client/app/android/java/src/org/chromium/blimp/BlimpClientSwitches.java View 1 chunk +0 lines, -21 lines 0 comments Download
M blimp/client/app/android/java/src/org/chromium/blimp/BlimpRendererActivity.java View 1 chunk +1 line, -0 lines 0 comments Download
D blimp/client/app/blimp_client_switches.h View 1 chunk +0 lines, -39 lines 0 comments Download
D blimp/client/app/blimp_client_switches.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M blimp/client/core/BUILD.gn View 2 chunks +13 lines, -0 lines 0 comments Download
A + blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientSwitches.java View 2 chunks +2 lines, -2 lines 0 comments Download
A + blimp/client/core/blimp_client_switches.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + blimp/client/core/blimp_client_switches.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M blimp/client/session/assignment_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/session/assignment_source_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/session/blimp_client_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/engine/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M blimp/engine/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + blimp/engine/browser_tests/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M blimp/engine/browser_tests/blimp_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
nyquist
dtrainor: PTAL
4 years, 5 months ago (2016-07-18 18:16:21 UTC) #2
David Trainor- moved to gerrit
lgtm
4 years, 5 months ago (2016-07-18 18:55:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154363002/1
4 years, 5 months ago (2016-07-18 20:07:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 21:24:03 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 21:24:31 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 21:27:14 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f0f0534e9be73b50afde189218160cf45648884
Cr-Commit-Position: refs/heads/master@{#406100}

Powered by Google App Engine
This is Rietveld 408576698