jni_generator: handle inner class natives properly.

jni_generator: handle inner class natives properly.

Inner classes with native methods but no @CalledByNative methods were
generating incorrect code that doesn't compile, but there was no example
of this in the sample class and so it wasn't noticed. Several of the
non-compiled test headers were doing this and the header was just
un-compilable as a result.

Fix this by including the class global's declaration and initialisation
in all the appropriate cases, and adding an example to the sample.

BUG=629103
R=rmcilroy@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/2eb44e80e1216124ced411b369a254d103d00cc3

[Torne, 2016-07-18 15:54:51]

torne@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[Torne, 2016-07-18 15:54:52]

Found this bug while trying to remove the native_exports option and make it
always true, as part of crbug.com/603936 :)

Turtles all the way down as usual.

[rmcilroy, 2016-07-19 09:09:20]

LGTM

[Torne, 2016-07-19 09:43:12]

The CQ bit was checked by torne@chromium.org

[commit-bot: I haz the power, 2016-07-19 09:43:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 10:03:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 10:03:13]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2016-07-19 11:39:22]

Description was changed from

==========
jni_generator: handle inner class natives properly.

Inner classes with native methods but no @CalledByNative methods were
generating incorrect code that doesn't compile, but there was no example
of this in the sample class and so it wasn't noticed. Several of the
non-compiled test headers were doing this and the header was just
un-compilable as a result.

Fix this by including the class global's declaration and initialisation
in all the appropriate cases, and adding an example to the sample.

BUG=629103
==========

to

==========
jni_generator: handle inner class natives properly.

Inner classes with native methods but no @CalledByNative methods were
generating incorrect code that doesn't compile, but there was no example
of this in the sample class and so it wasn't noticed. Several of the
non-compiled test headers were doing this and the header was just
un-compilable as a result.

Fix this by including the class global's declaration and initialisation
in all the appropriate cases, and adding an example to the sample.

BUG=629103
R=rmcilroy@chromium.org

Committed: https://crrev.com/2eb44e80e1216124ced411b369a254d103d00cc3
Cr-Commit-Position: refs/heads/master@{#406249}
==========

[commit-bot: I haz the power, 2016-07-19 11:39:23]

Patchset 1 (id:??) landed as
https://crrev.com/2eb44e80e1216124ced411b369a254d103d00cc3
Cr-Commit-Position: refs/heads/master@{#406249}

[Torne, 2016-07-19 11:40:02]

Description was changed from

==========
jni_generator: handle inner class natives properly.

Inner classes with native methods but no @CalledByNative methods were
generating incorrect code that doesn't compile, but there was no example
of this in the sample class and so it wasn't noticed. Several of the
non-compiled test headers were doing this and the header was just
un-compilable as a result.

Fix this by including the class global's declaration and initialisation
in all the appropriate cases, and adding an example to the sample.

BUG=629103
R=rmcilroy@chromium.org

Committed: https://crrev.com/2eb44e80e1216124ced411b369a254d103d00cc3
Cr-Commit-Position: refs/heads/master@{#406249}
==========

to

==========
jni_generator: handle inner class natives properly.

Inner classes with native methods but no @CalledByNative methods were
generating incorrect code that doesn't compile, but there was no example
of this in the sample class and so it wasn't noticed. Several of the
non-compiled test headers were doing this and the header was just
un-compilable as a result.

Fix this by including the class global's declaration and initialisation
in all the appropriate cases, and adding an example to the sample.

BUG=629103
R=rmcilroy@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/2eb44e80e1216124ced411b369a2...
==========

[Torne, 2016-07-19 11:40:04]

Committed patchset #1 (id:1) manually as
2eb44e80e1216124ced411b369a254d103d00cc3 (presubmit successful).