base/android/jni_generator/testInnerClassNativesMultiple.golden - Issue 2154293002: jni_generator: handle inner class natives properly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/android/jni_generator/testInnerClassNativesMultiple.golden

Issue 2154293002: jni_generator: handle inner class natives properly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/android/jni_generator/testInnerClassNativesBothInnerAndOuter.golden ('k') | base/android/jni_generator/testNativeExportsOptionalOption.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/android/jni_generator/testInnerClassNativesMultiple.golden

diff --git a/base/android/jni_generator/testInnerClassNativesMultiple.golden b/base/android/jni_generator/testInnerClassNativesMultiple.golden

index 268f794e9561b31a75131b2718912a95168ab0d5..a55e71f8d1f302d86c8317533d57d9bb58855786 100644

--- a/base/android/jni_generator/testInnerClassNativesMultiple.golden

+++ b/base/android/jni_generator/testInnerClassNativesMultiple.golden

@@ -23,8 +23,14 @@ const char kMyOtherInnerClassClassPath[] =

const char kTestJniClassPath[] = "org/chromium/TestJni";

const char kMyInnerClassClassPath[] = "org/chromium/TestJni$MyInnerClass";

// Leaking this jclass as we cannot use LazyInstance from some threads.

+jclass g_MyOtherInnerClass_clazz = NULL;

+#define MyOtherInnerClass_clazz(env) g_MyOtherInnerClass_clazz

+// Leaking this jclass as we cannot use LazyInstance from some threads.

jclass g_TestJni_clazz = NULL;

#define TestJni_clazz(env) g_TestJni_clazz

+// Leaking this jclass as we cannot use LazyInstance from some threads.

+jclass g_MyInnerClass_clazz = NULL;

+#define MyInnerClass_clazz(env) g_MyInnerClass_clazz

} // namespace

@@ -66,8 +72,12 @@ static const JNINativeMethod kMethodsMyInnerClass[] = {

static bool RegisterNativesImpl(JNIEnv* env) {

+ g_MyOtherInnerClass_clazz = reinterpret_cast<jclass>(env->NewGlobalRef(

+ base::android::GetClass(env, kMyOtherInnerClassClassPath).obj()));

g_TestJni_clazz = reinterpret_cast<jclass>(env->NewGlobalRef(

base::android::GetClass(env, kTestJniClassPath).obj()));

+ g_MyInnerClass_clazz = reinterpret_cast<jclass>(env->NewGlobalRef(

+ base::android::GetClass(env, kMyInnerClassClassPath).obj()));

const int kMethodsMyOtherInnerClassSize =

arraysize(kMethodsMyOtherInnerClass);