Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1841)

Unified Diff: content/renderer/render_frame_impl.h

Issue 2154233003: Rewrite YouTube Flash embeds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added unit tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index f3d5f6f9efa56b2ae067cbb308934bb5bdc6e9f0..301adb3d7d902b952b525e4da3c0fd8a347cc518 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -235,6 +235,10 @@ class CONTENT_EXPORT RenderFrameImpl
static blink::WebFrame* ResolveOpener(int opener_frame_routing_id,
int* opener_view_routing_id);
+ // Overwrites the URL and MIME type of a YouTube Flash embed to use an
mlamouri (slow - plz ping) 2016/07/20 13:22:02 ditto
kdsilva 2016/07/21 13:59:46 Done.
+ // HTML5 video player when possible.
+ bool overrideEmbedInfo(blink::WebString* url) override;
+
~RenderFrameImpl() override;
// Called by RenderWidget when meaningful layout has happened.
@@ -848,6 +852,7 @@ class CONTENT_EXPORT RenderFrameImpl
void OnSuppressFurtherDialogs();
void OnFileChooserResponse(
const std::vector<content::FileChooserFileInfo>& files);
+
mlamouri (slow - plz ping) 2016/07/20 13:22:02 nit: empty line again
kdsilva 2016/07/21 13:59:46 Done.
#if defined(OS_ANDROID)
void OnActivateNearestFindResult(int request_id, float x, float y);
void OnGetNearestFindResult(int request_id, float x, float y);

Powered by Google App Engine
This is Rietveld 408576698