Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Side by Side Diff: content/renderer/render_frame_impl.h

Issue 2154233003: Rewrite YouTube Flash embeds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added unit tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 228
229 // Looks up and returns the WebFrame corresponding to a given opener frame 229 // Looks up and returns the WebFrame corresponding to a given opener frame
230 // routing ID. Also stores the opener's RenderView routing ID into 230 // routing ID. Also stores the opener's RenderView routing ID into
231 // |opener_view_routing_id|. 231 // |opener_view_routing_id|.
232 // 232 //
233 // TODO(alexmos): remove RenderViewImpl's dependency on 233 // TODO(alexmos): remove RenderViewImpl's dependency on
234 // opener_view_routing_id. 234 // opener_view_routing_id.
235 static blink::WebFrame* ResolveOpener(int opener_frame_routing_id, 235 static blink::WebFrame* ResolveOpener(int opener_frame_routing_id,
236 int* opener_view_routing_id); 236 int* opener_view_routing_id);
237 237
238 // Overwrites the URL and MIME type of a YouTube Flash embed to use an
mlamouri (slow - plz ping) 2016/07/20 13:22:02 ditto
kdsilva 2016/07/21 13:59:46 Done.
239 // HTML5 video player when possible.
240 bool overrideEmbedInfo(blink::WebString* url) override;
241
238 ~RenderFrameImpl() override; 242 ~RenderFrameImpl() override;
239 243
240 // Called by RenderWidget when meaningful layout has happened. 244 // Called by RenderWidget when meaningful layout has happened.
241 // See RenderFrameObserver::DidMeaningfulLayout declaration for details. 245 // See RenderFrameObserver::DidMeaningfulLayout declaration for details.
242 void DidMeaningfulLayout(blink::WebMeaningfulLayout layout_type); 246 void DidMeaningfulLayout(blink::WebMeaningfulLayout layout_type);
243 247
244 // Out-of-process child frames receive a signal from RenderWidgetCompositor 248 // Out-of-process child frames receive a signal from RenderWidgetCompositor
245 // when a compositor frame has committed. 249 // when a compositor frame has committed.
246 void DidCommitCompositorFrame(); 250 void DidCommitCompositorFrame();
247 251
(...skipping 593 matching lines...) Expand 10 before | Expand all | Expand 10 after
841 void OnSerializeAsMHTML(const FrameMsg_SerializeAsMHTML_Params& params); 845 void OnSerializeAsMHTML(const FrameMsg_SerializeAsMHTML_Params& params);
842 void OnFind(int request_id, 846 void OnFind(int request_id,
843 const base::string16& search_text, 847 const base::string16& search_text,
844 const blink::WebFindOptions& options); 848 const blink::WebFindOptions& options);
845 void OnClearActiveFindMatch(); 849 void OnClearActiveFindMatch();
846 void OnStopFinding(StopFindAction action); 850 void OnStopFinding(StopFindAction action);
847 void OnEnableViewSourceMode(); 851 void OnEnableViewSourceMode();
848 void OnSuppressFurtherDialogs(); 852 void OnSuppressFurtherDialogs();
849 void OnFileChooserResponse( 853 void OnFileChooserResponse(
850 const std::vector<content::FileChooserFileInfo>& files); 854 const std::vector<content::FileChooserFileInfo>& files);
855
mlamouri (slow - plz ping) 2016/07/20 13:22:02 nit: empty line again
kdsilva 2016/07/21 13:59:46 Done.
851 #if defined(OS_ANDROID) 856 #if defined(OS_ANDROID)
852 void OnActivateNearestFindResult(int request_id, float x, float y); 857 void OnActivateNearestFindResult(int request_id, float x, float y);
853 void OnGetNearestFindResult(int request_id, float x, float y); 858 void OnGetNearestFindResult(int request_id, float x, float y);
854 void OnFindMatchRects(int current_version); 859 void OnFindMatchRects(int current_version);
855 #endif 860 #endif
856 861
857 #if defined(USE_EXTERNAL_POPUP_MENU) 862 #if defined(USE_EXTERNAL_POPUP_MENU)
858 #if defined(OS_MACOSX) 863 #if defined(OS_MACOSX)
859 void OnSelectPopupMenuItem(int selected_index); 864 void OnSelectPopupMenuItem(int selected_index);
860 #else 865 #else
(...skipping 440 matching lines...) Expand 10 before | Expand all | Expand 10 after
1301 mojom::FrameHostPtr frame_host_; 1306 mojom::FrameHostPtr frame_host_;
1302 1307
1303 base::WeakPtrFactory<RenderFrameImpl> weak_factory_; 1308 base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
1304 1309
1305 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl); 1310 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
1306 }; 1311 };
1307 1312
1308 } // namespace content 1313 } // namespace content
1309 1314
1310 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 1315 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698