Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/data/flash_embeds.html

Issue 2154233003: Rewrite YouTube Flash embeds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/renderer/chrome_content_renderer_client.cc ('K') | « chrome/renderer/chrome_content_renderer_client_unittest.cc ('k') | content/public/renderer/content_renderer_client.h » ('j') | third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/flash_embeds.html
diff --git a/chrome/test/data/flash_embeds.html b/chrome/test/data/flash_embeds.html
new file mode 100644
index 0000000000000000000000000000000000000000..c514334bf5136a8725617faf2711397218905be5
--- /dev/null
+++ b/chrome/test/data/flash_embeds.html
@@ -0,0 +1,15 @@
+<!DOCTYPE html>
+<html>
+ <head></head>
+ <body>
+ </body>
+ <script>
+ function appendToDOM(url) {
+ var object = document.createElement("object");
+ var embed = document.createElement("embed");
+ embed.src = url;
Mike West 2016/08/04 12:41:39 Nit: I'd like to see you check the `type` behavior
kdsilva 2016/08/05 11:06:02 Done.
+ object.appendChild(embed);
+ document.body.appendChild(object);
+ }
+ </script>
+</html>
« chrome/renderer/chrome_content_renderer_client.cc ('K') | « chrome/renderer/chrome_content_renderer_client_unittest.cc ('k') | content/public/renderer/content_renderer_client.h » ('j') | third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698