chrome/test/data/flash_embeds.html - Issue 2154233003: Rewrite YouTube Flash embeds

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/flash_embeds.html

Issue 2154233003: Rewrite YouTube Flash embeds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head></head>

	4 <body>

	5 </body>

	6 <script>

	7 function appendToDOM(url) {

	8 var object = document.createElement("object");

	9 var embed = document.createElement("embed");

	10 embed.src = url;
	Mike West 2016/08/04 12:41:39 Nit: I'd like to see you check the `type` behavior Nit: I'd like to see you check the `type` behavior as well, verifying that an explicit type is overwritten. kdsilva 2016/08/05 11:06:02 Done. Show quoted text On 2016/08/04 12:41:39, Mike West wrote: > Nit: I'd like to see you check the `type` behavior as well, verifying that an > explicit type is overwritten. Done.
	11 object.appendChild(embed);

	12 document.body.appendChild(object);

	13 }

	14 </script>

	15 </html>

OLD	NEW