Rewrite YouTube Flash embeds

third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

Index: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
index 4bec7cab5832b41887467b6fd69d423848aa384d..0dfc61d8aacaae174cd6348d6a6f9b443fbb262e 100644
--- a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
+++ b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
@@ -1035,4 +1035,11 @@ WebDevToolsAgentImpl* FrameLoaderClientImpl::devToolsAgent()
     return WebLocalFrameImpl::fromFrame(m_webFrame->frame()->localFrameRoot())->devToolsAgentImpl();
 }
 
+String FrameLoaderClientImpl::OverrideFlashEmbedWithHTML(const String& url)
+{
+    if (!m_webFrame->client())

[dcheng, 2016/08/01 14:50:34]

Why would we call this when client() is null? We shouldn't be loading plugins in
detached frames.

[kdsilva, 2016/08/02 15:34:46]

Done.

+        return "";

[dcheng, 2016/08/01 14:50:34]

As noted elsewhere, prefer returning the default constructed object rather than
constructing from an empty string literal.

[kdsilva, 2016/08/02 15:34:46]

Done.

+    return m_webFrame->client()->overrideFlashEmbedWithHTML(WebString(url));
+}
+
 } // namespace blink