Rewrite YouTube Flash embeds

third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

 /*
  * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 1017 matching lines @@
     if (m_webFrame->client())
         return m_webFrame->client()->getEffectiveConnectionType();
     return WebEffectiveConnectionType::TypeUnknown;
 }
 
 WebDevToolsAgentImpl* FrameLoaderClientImpl::devToolsAgent()
 {
     return WebLocalFrameImpl::fromFrame(m_webFrame->frame()->localFrameRoot())->devToolsAgentImpl();
 }
 
+String FrameLoaderClientImpl::OverrideFlashEmbedWithHTML(const String& url)
+{
+    if (!m_webFrame->client())

[dcheng, 2016/08/01 14:50:34]

Why would we call this when client() is null? We shouldn't be loading plugins in
detached frames.

[kdsilva, 2016/08/02 15:34:46]

Done.

+        return "";

[dcheng, 2016/08/01 14:50:34]

As noted elsewhere, prefer returning the default constructed object rather than
constructing from an empty string literal.

[kdsilva, 2016/08/02 15:34:46]

Done.

+    return m_webFrame->client()->overrideFlashEmbedWithHTML(WebString(url));
+}
+
 } // namespace blink