third_party/WebKit/Source/core/loader/EmptyClients.h - Issue 2154233003: Rewrite YouTube Flash embeds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/EmptyClients.h

Issue 2154233003: Rewrite YouTube Flash embeds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/EmptyClients.h

diff --git a/third_party/WebKit/Source/core/loader/EmptyClients.h b/third_party/WebKit/Source/core/loader/EmptyClients.h

index 72b4525e127bc526271215ed5030ce6d55328d8d..a07098e708e0d7a849d646c506d6ff82bd86a0f8 100644

--- a/third_party/WebKit/Source/core/loader/EmptyClients.h

+++ b/third_party/WebKit/Source/core/loader/EmptyClients.h

@@ -183,6 +183,9 @@ public:

class CORE_EXPORT EmptyFrameLoaderClient : public FrameLoaderClient {

WTF_MAKE_NONCOPYABLE(EmptyFrameLoaderClient);

public:

+ String OverrideFlashEmbedWithHTML(const String& url) override { return url; }

mlamouri (slow - plz ping) 2016/07/21 15:55:08 empty string?

kdsilva 2016/07/22 13:55:58 Done.

static EmptyFrameLoaderClient* create() { return new EmptyFrameLoaderClient; }

~EmptyFrameLoaderClient() override {}