 Chromium Code Reviews
 Chromium Code Reviews Issue 2154233003:
  Rewrite YouTube Flash embeds  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 2154233003:
  Rewrite YouTube Flash embeds  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW | 
|---|---|
| 1 /* | 1 /* | 
| 2 * Copyright (C) 2006 Eric Seidel (eric@webkit.org) | 2 * Copyright (C) 2006 Eric Seidel (eric@webkit.org) | 
| 3 * Copyright (C) 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. | 3 * Copyright (C) 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. | 
| 4 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). | 4 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). | 
| 5 * Copyright (C) 2012 Samsung Electronics. All rights reserved. | 5 * Copyright (C) 2012 Samsung Electronics. All rights reserved. | 
| 6 * | 6 * | 
| 7 * Redistribution and use in source and binary forms, with or without | 7 * Redistribution and use in source and binary forms, with or without | 
| 8 * modification, are permitted provided that the following conditions | 8 * modification, are permitted provided that the following conditions | 
| 9 * are met: | 9 * are met: | 
| 10 * 1. Redistributions of source code must retain the above copyright | 10 * 1. Redistributions of source code must retain the above copyright | 
| (...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 176 | 176 | 
| 177 void registerPopupOpeningObserver(PopupOpeningObserver*) override {} | 177 void registerPopupOpeningObserver(PopupOpeningObserver*) override {} | 
| 178 void unregisterPopupOpeningObserver(PopupOpeningObserver*) override {} | 178 void unregisterPopupOpeningObserver(PopupOpeningObserver*) override {} | 
| 179 | 179 | 
| 180 std::unique_ptr<WebFrameScheduler> createFrameScheduler(BlameContext*) overr ide; | 180 std::unique_ptr<WebFrameScheduler> createFrameScheduler(BlameContext*) overr ide; | 
| 181 }; | 181 }; | 
| 182 | 182 | 
| 183 class CORE_EXPORT EmptyFrameLoaderClient : public FrameLoaderClient { | 183 class CORE_EXPORT EmptyFrameLoaderClient : public FrameLoaderClient { | 
| 184 WTF_MAKE_NONCOPYABLE(EmptyFrameLoaderClient); | 184 WTF_MAKE_NONCOPYABLE(EmptyFrameLoaderClient); | 
| 185 public: | 185 public: | 
| 186 | |
| 187 String OverrideFlashEmbedWithHTML(const String& url) override { return url; } | |
| 
mlamouri (slow - plz ping)
2016/07/21 15:55:08
empty string?
 
kdsilva
2016/07/22 13:55:58
Done.
 | |
| 188 | |
| 186 static EmptyFrameLoaderClient* create() { return new EmptyFrameLoaderClient; } | 189 static EmptyFrameLoaderClient* create() { return new EmptyFrameLoaderClient; } | 
| 187 ~EmptyFrameLoaderClient() override {} | 190 ~EmptyFrameLoaderClient() override {} | 
| 188 | 191 | 
| 189 bool hasWebView() const override { return true; } // mainly for assertions | 192 bool hasWebView() const override { return true; } // mainly for assertions | 
| 190 | 193 | 
| 191 bool inShadowTree() const override { return false; } | 194 bool inShadowTree() const override { return false; } | 
| 192 | 195 | 
| 193 Frame* opener() const override { return 0; } | 196 Frame* opener() const override { return 0; } | 
| 194 void setOpener(Frame*) override {} | 197 void setOpener(Frame*) override {} | 
| 195 | 198 | 
| (...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 329 ~EmptyContextMenuClient() override {} | 332 ~EmptyContextMenuClient() override {} | 
| 330 bool showContextMenu(const ContextMenu*, bool) override { return false; } | 333 bool showContextMenu(const ContextMenu*, bool) override { return false; } | 
| 331 void clearContextMenu() override {} | 334 void clearContextMenu() override {} | 
| 332 }; | 335 }; | 
| 333 | 336 | 
| 334 CORE_EXPORT void fillWithEmptyClients(Page::PageClients&); | 337 CORE_EXPORT void fillWithEmptyClients(Page::PageClients&); | 
| 335 | 338 | 
| 336 } // namespace blink | 339 } // namespace blink | 
| 337 | 340 | 
| 338 #endif // EmptyClients_h | 341 #endif // EmptyClients_h | 
| OLD | NEW |