Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9095)

Unified Diff: chrome/browser/resources/options/preferences.js

Issue 215423002: [Hotword] Make ConfirmDialog subclass from SettingsDialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: some more cleanup Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/preferences.js
diff --git a/chrome/browser/resources/options/preferences.js b/chrome/browser/resources/options/preferences.js
index 6f8cc8294176437ecb8a82f8dbcb37db9086fac6..ecbe1ec8d586ba2368092f1e6753adc7cb30f9f3 100644
--- a/chrome/browser/resources/options/preferences.js
+++ b/chrome/browser/resources/options/preferences.js
@@ -216,8 +216,8 @@ cr.define('options', function() {
// Decorate pref value as CoreOptionsHandler::CreateValueForPref() does.
event.value = {
value: value,
- recommendedValue: pref.orig.recommendedValue,
- disabled: pref.orig.disabled,
+ recommendedValue: pref.orig ? pref.orig.recommendedValue : undefined,
+ disabled: pref.orig ? pref.orig.disabled : undefined,
uncommitted: true,
};
Dan Beam 2014/03/27 21:06:43 nit: event.value = {value: value, uncommitted: tr
rpetterson 2014/03/27 21:26:00 Done.
this.dispatchEvent(event);
« chrome/browser/resources/options/pref_ui.js ('K') | « chrome/browser/resources/options/pref_ui.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698