Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/options/pref_ui.js

Issue 215423002: [Hotword] Make ConfirmDialog subclass from SettingsDialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: some more cleanup Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/resources/options/confirm_dialog.js ('K') | « chrome/browser/resources/options/hotword_confirm_overlay.html ('k') | chrome/browser/resources/options/preferences.js » ('j') | chrome/browser/resources/options/preferences.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/pref_ui.js
diff --git a/chrome/browser/resources/options/pref_ui.js b/chrome/browser/resources/options/pref_ui.js
index 0775306d77676ec13863ebacff2de0c77c52fc71..d72411e390bc440c612af9d6eda93091693311f2 100644
--- a/chrome/browser/resources/options/pref_ui.js
+++ b/chrome/browser/resources/options/pref_ui.js
@@ -160,6 +160,10 @@ cr.define('options', function() {
decorate: function() {
PrefInputElement.prototype.decorate.call(this);
this.type = 'checkbox';
+
+ // Prime the checkbox pref, as it may be default-checked.
Dan Beam 2014/03/27 21:06:43 i have no idea what this means.
rpetterson 2014/03/27 21:26:00 The preference may be default true.
Dan Beam 2014/03/28 00:00:41 just remove the comment, imo
rpetterson 2014/03/28 00:05:35 Done.
+ if (this.dialogPref)
+ this.updatePrefFromState_();
},
/**
« chrome/browser/resources/options/confirm_dialog.js ('K') | « chrome/browser/resources/options/hotword_confirm_overlay.html ('k') | chrome/browser/resources/options/preferences.js » ('j') | chrome/browser/resources/options/preferences.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698