Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2154223003: Revert of [Skia] Convert Sk Images to a CIPD package (Closed)

Created:
4 years, 5 months ago by borenet
Modified:
4 years, 5 months ago
Reviewers:
borenet2, rmistry
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of [Skia] Convert Sk Images to a CIPD package (patchset #1 id:1 of https://codereview.chromium.org/2162563002/ ) Reason for revert: Breaking bots Original issue's description: > [Skia] Convert Sk Images to a CIPD package > > BUG=skia:5427 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/e4607f99670139e478d2f4a0255c16eae2ef293c TBR=rmistry@google.com,borenet@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:5427 Committed: https://chromium.googlesource.com/chromium/tools/build/+/4024e317d73097e651ba6a88a3916a9c1f47ef72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -2034 lines) Patch
M scripts/slave/recipe_modules/skia/api.py View 2 chunks +8 lines, -22 lines 0 comments Download
M scripts/slave/recipe_modules/skia/default_flavor.py View 1 chunk +4 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_perf.expected/Perf-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Release.json View 1 chunk +2 lines, -12 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_perf.expected/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-VisualBench.json View 2 chunks +3 lines, -13 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_perf.expected/Perf-Win-MSVC-GCE-CPU-AVX2-x86_64-Release.json View 2 chunks +3 lines, -13 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_perf.expected/Perf-Win8-MSVC-ShuttleB-GPU-HD4600-x86_64-Release-Trybot.json View 2 chunks +3 lines, -13 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_perf.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 3 chunks +4 lines, -14 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_perf.expected/big_issue_number.json View 2 chunks +3 lines, -13 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.py View 1 chunk +0 lines, -16 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Android-GCC-GalaxyS3-GPU-Mali400-Arm7-Debug.json View 1 chunk +2 lines, -12 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Debug.json View 1 chunk +2 lines, -12 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot.json View 3 chunks +4 lines, -14 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug.json View 3 chunks +4 lines, -14 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN.json View 3 chunks +4 lines, -14 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 7 chunks +8 lines, -18 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release-Trybot.json View 3 chunks +4 lines, -14 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug.json View 3 chunks +4 lines, -14 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/adb_in_path.json View 1 chunk +2 lines, -12 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/big_issue_number.json View 3 chunks +4 lines, -14 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/download_and_push_skimage.json View 3 chunks +4 lines, -14 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/download_and_push_skps.json View 1 chunk +2 lines, -12 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/failed_dm.json View 3 chunks +4 lines, -14 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/failed_get_hashes.json View 1 chunk +2 lines, -12 lines 0 comments Download
D scripts/slave/recipes/skia/swarm_test.expected/legacy_skimage_version.json View 1 chunk +0 lines, -242 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/missing_SKP_VERSION_device.json View 1 chunk +2 lines, -12 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/missing_SK_IMAGE_VERSION_device.json View 3 chunks +4 lines, -14 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.py View 4 chunks +8 lines, -25 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/No_downloaded_SKP_VERSION.json View 3 chunks +12 lines, -6 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Trybot.json View 2 chunks +12 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Android-GCC-NVIDIA_Shield-GPU-TegraX1-Arm64-Debug-Vulkan.json View 3 chunks +12 lines, -6 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Android-GCC-Nexus7v2-GPU-Tegra3-Arm7-Release.json View 2 chunks +12 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release.json View 2 chunks +12 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot.json View 2 chunks +12 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug.json View 3 chunks +12 lines, -6 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN.json View 3 chunks +12 lines, -6 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 3 chunks +12 lines, -6 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Win8-MSVC-ShuttleA-GPU-HD7770-x86_64-Release.json View 2 chunks +12 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release.json View 2 chunks +12 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release.json View 2 chunks +12 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Wrong_downloaded_SKP_VERSION.json View 3 chunks +12 lines, -6 lines 0 comments Download
D scripts/slave/recipes/skia/swarm_trigger.expected/legacy_skimage_version.json View 1 chunk +0 lines, -1369 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
borenet
Created Revert of [Skia] Convert Sk Images to a CIPD package
4 years, 5 months ago (2016-07-18 16:12:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154223003/1
4 years, 5 months ago (2016-07-18 16:12:44 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-18 16:12:46 UTC) #5
borenet2
On 2016/07/18 16:12:46, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
4 years, 5 months ago (2016-07-18 16:13:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154223003/1
4 years, 5 months ago (2016-07-18 16:14:11 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 16:14:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/4024e317d73097e651ba...

Powered by Google App Engine
This is Rietveld 408576698