scripts/slave/recipes/skia/swarm_trigger.expected/Wrong_downloaded_SKP_VERSION.json - Issue 2154223003: Revert of [Skia] Convert Sk Images to a CIPD package

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/skia/swarm_trigger.expected/Wrong_downloaded_SKP_VERSION.json

Issue 2154223003: Revert of [Skia] Convert Sk Images to a CIPD package (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/skia/swarm_trigger.expected/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release.json ('k') | scripts/slave/recipes/skia/swarm_trigger.expected/legacy_skimage_version.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/skia/swarm_trigger.expected/Wrong_downloaded_SKP_VERSION.json

diff --git a/scripts/slave/recipes/skia/swarm_trigger.expected/Wrong_downloaded_SKP_VERSION.json b/scripts/slave/recipes/skia/swarm_trigger.expected/Wrong_downloaded_SKP_VERSION.json

index fecd054f27435cc33365bf6272142a136672e527..e2b64c0c404da72960d2813027e33a85983a8017 100644

--- a/scripts/slave/recipes/skia/swarm_trigger.expected/Wrong_downloaded_SKP_VERSION.json

+++ b/scripts/slave/recipes/skia/swarm_trigger.expected/Wrong_downloaded_SKP_VERSION.json

@@ -801,10 +801,20 @@

"python",

"-u",

"\nimport shutil\nimport sys\nshutil.copy(sys.argv[1], sys.argv[2])\n",

- "[SLAVE_BUILD]/skia/infra/bots/assets/skimage/VERSION",

+ "[SLAVE_BUILD]/tmp/SK_IMAGE_VERSION",

"/path/to/tmp/"

- "name": "read skimage VERSION"

+ "name": "Get downloaded SK_IMAGE_VERSION"

+ },

+ {

+ "cmd": [

+ "python",

+ "-u",

+ "\nimport shutil\nimport sys\nshutil.copy(sys.argv[1], sys.argv[2])\n",

+ "[SLAVE_BUILD]/skia/SK_IMAGE_VERSION",

+ "/path/to/tmp/"

+ ],

+ "name": "Get expected SK_IMAGE_VERSION"

{

"cmd": [

@@ -951,8 +961,6 @@

"slavename:skiabot-linux-test-000",

"--tag",

"stepname:test_skia on Ubuntu",

- "--cipd-package",

- "skimage:skia/bots/skimage:version:0",

"def456",

"--",

"--workdir",

@@ -1127,8 +1135,6 @@