Settings Router Refactor: Clean up Quick Unlock (and a few misc fixes)

Settings Router Refactor: Clean up Quick Unlock (and a few misc fixes).

This mostly cleans up some routing code in Quick Unlock. It also has a few small fixes in People.

BUG=608115
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a8671b2f203fbf69b9feb2014664df0d6fdf5b1e
Cr-Commit-Position: refs/heads/master@{#408736}

[tommycli, 2016-07-21 00:05:13]

Description was changed from

==========
Settings Router Refactor: Make some cleanups enabled by new routes.

This cleans up some particularly verbose usages of the old routes system
and uses the new settings.Route constants to write cleaner replacements.

BUG=608115
==========

to

==========
Settings Router Refactor: Make some cleanups enabled by new routes.

This cleans up some particularly verbose usages of the old routes system
and uses the new settings.Route constants to write cleaner replacements.

BUG=608115
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-07-21 00:05:30]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 00:06:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 00:09:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 00:09:16]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[tommycli, 2016-07-25 20:58:20]

Patchset #2 (id:20001) has been deleted

[tommycli, 2016-07-25 20:59:41]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 21:00:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 21:04:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 21:04:05]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[tommycli, 2016-07-25 22:54:45]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 22:55:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 22:58:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 22:58:21]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[tommycli, 2016-07-25 23:39:08]

Description was changed from

==========
Settings Router Refactor: Make some cleanups enabled by new routes.

This cleans up some particularly verbose usages of the old routes system
and uses the new settings.Route constants to write cleaner replacements.

BUG=608115
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings Router Refactor: Clean up Quick Unlock (and a few misc fixes).

This mostly cleans up some routing code in Quick Unlock. It also has a few small
fixes in People.

BUG=608115
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-07-25 23:39:08]

tommycli@chromium.org changed reviewers:
+ jdufault@chromium.org

[tommycli, 2016-07-25 23:47:46]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 23:48:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-07-25 23:52:36]

jdufault: PTAL. Mostly Quick Unlock stuff. A few other misc. changes of the same
nature in other parts of Settings and People.

[jdufault, 2016-07-26 00:09:58]

lgtm, nice cleanup!

[tommycli, 2016-07-28 21:42:32]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-07-28 21:42:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
jdufault@chromium.org
Link to the patchset: https://codereview.chromium.org/2154213008/#ps120001
(title: "merge origin/master")

[commit-bot: I haz the power, 2016-07-28 21:42:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 22:20:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 22:20:55]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tommycli, 2016-07-28 23:16:56]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 23:17:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 00:14:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 00:14:55]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tommycli, 2016-07-29 18:55:49]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 18:56:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-07-29 19:26:16]

The CQ bit was unchecked by tommycli@chromium.org

[tommycli, 2016-07-29 19:26:16]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-07-29 19:26:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
jdufault@chromium.org
Link to the patchset: https://codereview.chromium.org/2154213008/#ps160001
(title: "change test")

[commit-bot: I haz the power, 2016-07-29 19:26:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 21:00:00]

Description was changed from

==========
Settings Router Refactor: Clean up Quick Unlock (and a few misc fixes).

This mostly cleans up some routing code in Quick Unlock. It also has a few small
fixes in People.

BUG=608115
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings Router Refactor: Clean up Quick Unlock (and a few misc fixes).

This mostly cleans up some routing code in Quick Unlock. It also has a few small
fixes in People.

BUG=608115
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-07-29 21:00:01]

Committed patchset #8 (id:160001)

[commit-bot: I haz the power, 2016-07-29 21:02:31]

Description was changed from

==========
Settings Router Refactor: Clean up Quick Unlock (and a few misc fixes).

This mostly cleans up some routing code in Quick Unlock. It also has a few small
fixes in People.

BUG=608115
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings Router Refactor: Clean up Quick Unlock (and a few misc fixes).

This mostly cleans up some routing code in Quick Unlock. It also has a few small
fixes in People.

BUG=608115
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a8671b2f203fbf69b9feb2014664df0d6fdf5b1e
Cr-Commit-Position: refs/heads/master@{#408736}
==========

[commit-bot: I haz the power, 2016-07-29 21:02:33]

Patchset 8 (id:??) landed as
https://crrev.com/a8671b2f203fbf69b9feb2014664df0d6fdf5b1e
Cr-Commit-Position: refs/heads/master@{#408736}