chrome/browser/resources/settings/appearance_page/appearance_page.js - Issue 2154213008: Settings Router Refactor: Clean up Quick Unlock (and a few misc fixes)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_page.js

Issue 2154213008: Settings Router Refactor: Clean up Quick Unlock (and a few misc fixes) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0211-settings-router-impl-part-3-navigateTo

Patch Set: change test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/appearance_page/appearance_page.js

diff --git a/chrome/browser/resources/settings/appearance_page/appearance_page.js b/chrome/browser/resources/settings/appearance_page/appearance_page.js

index 083685b01c07bf3d7fe6dd0632389edcb4a14b56..f5e2d83819a304b61d66997b827d2e305d2c104f 100644

--- a/chrome/browser/resources/settings/appearance_page/appearance_page.js

+++ b/chrome/browser/resources/settings/appearance_page/appearance_page.js

@@ -190,7 +190,7 @@ Polymer({

/** @private */

showFontsPage_: function() {

- return this.currentRoute.subpage[0] == 'appearance-fonts';

+ return this.currentRoute == settings.Route.FONTS;

/**

« no previous file with comments | « no previous file | chrome/browser/resources/settings/device_page/device_page.js » ('j') | no next file with comments »