Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 2154213007: Replace gfx::Rect with gfx::RectF in ui::AXNodeData (Closed)

Created:
4 years, 5 months ago by dmazzoni
Modified:
4 years, 5 months ago
Reviewers:
Tom Sepez, aboxhall
CC:
aboxhall+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, extensions-reviews_chromium.org, jam, je_julie, mlamouri+watch-content_chromium.org, nektar+watch_chromium.org, tfarina, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace gfx::Rect with gfx::RectF in ui::AXNodeData This is a mechanical change to switch to using floating-point rects internally for accessible bounding boxes. In cases where we need to convert back to a gfx::Rect, we use gfx::ToEnclosingRect. This change is necessary so that in the future we can use relative bounding boxes and transformation matrices in the accessibility tree. In isolation this change should have no effect except that objects might be off by one pixel due to differences in when rounding happens. BUG=618120 Committed: https://crrev.com/7535c4d868bff31a671bfe956c08cf3a7c381109 Cr-Commit-Position: refs/heads/master@{#406963}

Patch Set 1 #

Patch Set 2 : Fix content_unittests #

Patch Set 3 : Fix win compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -47 lines) Patch
M chrome/renderer/extensions/automation_internal_custom_bindings.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/pdf/renderer/pdf_accessibility_tree.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter_blink.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_unittest.cc View 1 8 chunks +14 lines, -14 lines 0 comments Download
M content/common/accessibility_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/accessibility/render_accessibility_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/accessibility/render_accessibility_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/accessibility/ax_node.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/accessibility/ax_node.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/accessibility/ax_node_data.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/accessibility/ax_tree_combiner.cc View 1 chunk +1 line, -4 lines 0 comments Download
M ui/accessibility/ax_tree_combiner_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/accessibility/ax_tree_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_auralinux.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/accessibility/platform/ax_platform_node_base.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/accessibility/platform/ax_platform_node_win.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M ui/accessibility/platform/ax_platform_node_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/accessibility/ax_view_obj_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/accessibility/ax_widget_obj_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/accessibility/ax_window_obj_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/accessibility/native_view_accessibility.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/accessibility/native_view_accessibility_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 23 (16 generated)
dmazzoni
4 years, 5 months ago (2016-07-21 16:58:22 UTC) #14
aboxhall
lgtm
4 years, 5 months ago (2016-07-21 21:44:18 UTC) #15
dmazzoni
+tsepez for content/common/accessibility_messages.h (If looks good could you cq+ too?)
4 years, 5 months ago (2016-07-21 21:50:02 UTC) #17
Tom Sepez
lgtm
4 years, 5 months ago (2016-07-21 22:06:35 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154213007/40001
4 years, 5 months ago (2016-07-21 22:07:21 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-21 22:13:00 UTC) #21
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 22:14:08 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7535c4d868bff31a671bfe956c08cf3a7c381109
Cr-Commit-Position: refs/heads/master@{#406963}

Powered by Google App Engine
This is Rietveld 408576698