components/pdf/renderer/pdf_accessibility_tree.cc - Issue 2154213007: Replace gfx::Rect with gfx::RectF in ui::AXNodeData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/pdf/renderer/pdf_accessibility_tree.cc

Issue 2154213007: Replace gfx::Rect with gfx::RectF in ui::AXNodeData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix win compile Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/extensions/automation_internal_custom_bindings.cc ('k') | content/browser/accessibility/accessibility_tree_formatter_blink.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/pdf/renderer/pdf_accessibility_tree.cc

diff --git a/components/pdf/renderer/pdf_accessibility_tree.cc b/components/pdf/renderer/pdf_accessibility_tree.cc

index 92e5cbba1dfe22f377856c2e0182a8ca06fa31b1..104679a09580cac7d364832e48b6f97c05afd1d3 100644

--- a/components/pdf/renderer/pdf_accessibility_tree.cc

+++ b/components/pdf/renderer/pdf_accessibility_tree.cc

@@ -91,7 +91,7 @@ void PdfAccessibilityTree::SetAccessibilityPageInfo(

page_bounds += offset_;

page_bounds -= scroll_;

page_bounds.Scale(zoom_ / GetDeviceScaleFactor());

- page_node->location = gfx::ToEnclosingRect(page_bounds);

+ page_node->location = page_bounds;

doc_node_->location.Union(page_node->location);

doc_node_->child_ids.push_back(page_node->id);

@@ -141,7 +141,7 @@ void PdfAccessibilityTree::SetAccessibilityPageInfo(

gfx::RectF text_run_bounds = ToGfxRectF(text_run.bounds);

text_run_bounds.Scale(zoom_ / GetDeviceScaleFactor());

text_run_bounds += page_bounds.OffsetFromOrigin();

- inline_text_box_node->location = gfx::ToEnclosingRect(text_run_bounds);

+ inline_text_box_node->location = text_run_bounds;

inline_text_box_node->AddIntListAttribute(ui::AX_ATTR_CHARACTER_OFFSETS,

char_offsets);