Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2154213002:
Adding SSL Max Version flag to chrome://flags. (Closed)
DescriptionAdding SSL Max Version flag to chrome://flags.
BUG=
Committed: https://crrev.com/298f5448ef20f0bec798607c9731be0024e79454
Cr-Commit-Position: refs/heads/master@{#406141}
Patch Set 1 #
Total comments: 8
Patch Set 2 : Fixing comments. #Patch Set 3 : Fix naming. #Patch Set 4 : Adding histograms for chrome://flags #
Depends on Patchset: Messages
Total messages: 42 (23 generated)
Description was changed from ========== Adding SSL Max Version flag to chrome://flags. BUG= ========== to ========== Adding SSL Max Version flag to chrome://flags. BUG= ==========
svaldez@chromium.org changed reviewers: + davidben@chromium.org
https://codereview.chromium.org/2154213002/diff/1/chrome/app/generated_resour... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2154213002/diff/1/chrome/app/generated_resour... chrome/app/generated_resources.grd:5631: + <message name="IDS_FLAGS_SSL_VERSION_MAX_NAME" desc="Title for the flag to switch the max SSL version."> max -> maximum https://codereview.chromium.org/2154213002/diff/1/chrome/app/generated_resour... chrome/app/generated_resources.grd:5632: + SSL Version Max Max -> Maximum. To match the old one, let's write "Maximum TLS version supported." (The old one was "Minimum SSL/TLS version supported") I honestly could care less about SSL vs TLS, but I guess we may as well use TLS to avoid pedantic people complaining because it will definitely come up. :-) https://codereview.chromium.org/2154213002/diff/1/chrome/app/generated_resour... chrome/app/generated_resources.grd:5634: + <message name="IDS_FLAGS_SSL_VERSION_MAX_DESCRIPTION" desc="Description for the flag to switch the max SSL version."> max -> maximum https://codereview.chromium.org/2154213002/diff/1/chrome/app/generated_resour... chrome/app/generated_resources.grd:5635: + Set max supported SSL version. max -> maximum
https://codereview.chromium.org/2154213002/diff/1/chrome/app/generated_resour... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2154213002/diff/1/chrome/app/generated_resour... chrome/app/generated_resources.grd:5631: + <message name="IDS_FLAGS_SSL_VERSION_MAX_NAME" desc="Title for the flag to switch the max SSL version."> On 2016/07/18 14:11:32, davidben (OOO until 7-25) wrote: > max -> maximum Done. https://codereview.chromium.org/2154213002/diff/1/chrome/app/generated_resour... chrome/app/generated_resources.grd:5632: + SSL Version Max On 2016/07/18 14:11:32, davidben (OOO until 7-25) wrote: > Max -> Maximum. > > To match the old one, let's write "Maximum TLS version supported." (The old one > was "Minimum SSL/TLS version supported") > > I honestly could care less about SSL vs TLS, but I guess we may as well use TLS > to avoid pedantic people complaining because it will definitely come up. :-) Done. https://codereview.chromium.org/2154213002/diff/1/chrome/app/generated_resour... chrome/app/generated_resources.grd:5634: + <message name="IDS_FLAGS_SSL_VERSION_MAX_DESCRIPTION" desc="Description for the flag to switch the max SSL version."> On 2016/07/18 14:11:32, davidben (OOO until 7-25) wrote: > max -> maximum Done. https://codereview.chromium.org/2154213002/diff/1/chrome/app/generated_resour... chrome/app/generated_resources.grd:5635: + Set max supported SSL version. On 2016/07/18 14:11:32, davidben (OOO until 7-25) wrote: > max -> maximum Done.
lgtm
The CQ bit was checked by svaldez@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2083743002 Patch 60001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by svaldez@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2083743002 Patch 60001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by svaldez@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2083743002 Patch 60001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by svaldez@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2083743002 Patch 60001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by svaldez@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by svaldez@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
svaldez@chromium.org changed reviewers: + asvitkine@google.com
Hi, asvitkine: This histograms change is required for adding the max version flag for SSL to chrome://flags, could you take a look and give OWNERS approval. Thanks, Steven
(still lgtm on my end)
asvitkine@chromium.org changed reviewers: + asvitkine@chromium.org
lgtm
The CQ bit was unchecked by svaldez@chromium.org
The CQ bit was unchecked by svaldez@chromium.org
The CQ bit was checked by svaldez@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by davidben@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Adding SSL Max Version flag to chrome://flags. BUG= ========== to ========== Adding SSL Max Version flag to chrome://flags. BUG= ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Adding SSL Max Version flag to chrome://flags. BUG= ========== to ========== Adding SSL Max Version flag to chrome://flags. BUG= Committed: https://crrev.com/298f5448ef20f0bec798607c9731be0024e79454 Cr-Commit-Position: refs/heads/master@{#406141} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/298f5448ef20f0bec798607c9731be0024e79454 Cr-Commit-Position: refs/heads/master@{#406141} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
