Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3201)

Unified Diff: chrome/browser/about_flags.cc

Issue 2154213002: Adding SSL Max Version flag to chrome://flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tls13_const
Patch Set: Adding histograms for chrome://flags Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 11c193fd4fa67ee54a091f44d1a49bfddf226f56..8dea7be05ad3ec9915ef6e5c31f068b4fa28eb24 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -53,6 +53,7 @@
#include "components/search/search_switches.h"
#include "components/security_state/switches.h"
#include "components/signin/core/common/signin_switches.h"
+#include "components/ssl_config/ssl_config_switches.h"
#include "components/sync_driver/sync_driver_switches.h"
#include "components/tracing/common/tracing_switches.h"
#include "components/translate/core/browser/translate_prefs.h"
@@ -591,6 +592,12 @@ const FeatureEntry::Choice kEnableWebFontsInterventionV2Choices[] = {
switches::kEnableWebFontsInterventionV2SwitchValueDisabled},
};
+const FeatureEntry::Choice kSSLVersionMaxChoices[] = {
+ {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
+ {IDS_FLAGS_SSL_VERSION_MAX_TLS12, switches::kSSLVersionMax, "tls1.2"},
+ {IDS_FLAGS_SSL_VERSION_MAX_TLS13, switches::kSSLVersionMax, "tls1.3"},
+};
+
// RECORDING USER METRICS FOR FLAGS:
// -----------------------------------------------------------------------------
// The first line of the entry is the internal name. If you'd like to gather
@@ -1797,6 +1804,9 @@ const FeatureEntry kFeatureEntries[] = {
{"enable-grouped-history", IDS_FLAGS_ENABLE_GROUPED_HISTORY_NAME,
IDS_FLAGS_ENABLE_GROUPED_HISTORY_DESCRIPTION, kOsDesktop,
SINGLE_VALUE_TYPE(switches::kHistoryEnableGroupByDomain)},
+ {"ssl-version-max", IDS_FLAGS_SSL_VERSION_MAX_NAME,
+ IDS_FLAGS_SSL_VERSION_MAX_DESCRIPTION, kOsAll,
+ MULTI_VALUE_TYPE(kSSLVersionMaxChoices)},
{"enable-token-binding", IDS_FLAGS_ENABLE_TOKEN_BINDING_NAME,
IDS_FLAGS_ENABLE_TOKEN_BINDING_DESCRIPTION, kOsAll,
FEATURE_VALUE_TYPE(features::kTokenBinding)},
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698