Implement WebGL2 PixelStorei params constraints.

Implement WebGL2 PixelStorei params constraints.

BUG=628866
TEST=webgl2_conformance
R=piman@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/d0d61973aa559edd9c82afa109f032a243e45f88
Cr-Commit-Position: refs/heads/master@{#406214}

[Zhenyao Mo, 2016-07-18 03:03:56]

Description was changed from

==========
Implement WebGL2 PixelStorei params constraints.

BUG=628866
TEST=webgl2_conformance
R=piman@chromium.org
==========

to

==========
Implement WebGL2 PixelStorei params constraints.

BUG=628866
TEST=webgl2_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-07-18 16:50:25]

piman: Please review.

Although it's WebGL specific changes, but to me it's simpler to constraint it in
command buffer for all ES3 contexts.  All DEQP tests are conformant to these
constraints, so anything outside it are bug prone (and we do see many of them)

Here is the pull request to adjust the tests:

https://github.com/KhronosGroup/WebGL/pull/1903

They all pass with the pull request and CL.

I'll make sure only landing when the test changes are rolled in.

[Zhenyao Mo, 2016-07-18 16:50:48]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 16:51:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 17:18:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 17:18:37]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Zhenyao Mo, 2016-07-18 18:06:35]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 18:07:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 19:08:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 19:08:28]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[piman, 2016-07-18 22:01:45]

LGTM, this seems mostly harmless. Can you just leave a comment indicating that
this check goes beyond ES3, but is needed for WebGL2, in case we need to weaken
it later?

[Zhenyao Mo, 2016-07-19 00:36:26]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2016-07-19 00:36:26]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2154153002/#ps60001
(title: "Implement WebGL2 PixelStorei params constraints.")

[commit-bot: I haz the power, 2016-07-19 00:37:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 01:36:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 01:36:14]

Try jobs failed on following builders:
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[Zhenyao Mo, 2016-07-19 04:31:46]

Description was changed from

==========
Implement WebGL2 PixelStorei params constraints.

BUG=628866
TEST=webgl2_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Implement WebGL2 PixelStorei params constraints.

BUG=628866
TEST=webgl2_conformance
R=piman@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-07-19 04:31:52]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2016-07-19 04:31:53]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2154153002/#ps80001
(title: "update test expectations")

[commit-bot: I haz the power, 2016-07-19 04:32:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 04:36:59]

Description was changed from

==========
Implement WebGL2 PixelStorei params constraints.

BUG=628866
TEST=webgl2_conformance
R=piman@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Implement WebGL2 PixelStorei params constraints.

BUG=628866
TEST=webgl2_conformance
R=piman@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-07-19 04:37:00]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-19 04:37:04]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 04:38:26]

Description was changed from

==========
Implement WebGL2 PixelStorei params constraints.

BUG=628866
TEST=webgl2_conformance
R=piman@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Implement WebGL2 PixelStorei params constraints.

BUG=628866
TEST=webgl2_conformance
R=piman@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/d0d61973aa559edd9c82afa109f032a243e45f88
Cr-Commit-Position: refs/heads/master@{#406214}
==========

[commit-bot: I haz the power, 2016-07-19 04:38:27]

Patchset 5 (id:??) landed as
https://crrev.com/d0d61973aa559edd9c82afa109f032a243e45f88
Cr-Commit-Position: refs/heads/master@{#406214}