Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: gpu/command_buffer/client/gles2_implementation_unittest.cc

Issue 2154153002: Implement WebGL2 PixelStorei params constraints. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update test expectations Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/client/gles2_implementation.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/client/gles2_implementation_unittest.cc
diff --git a/gpu/command_buffer/client/gles2_implementation_unittest.cc b/gpu/command_buffer/client/gles2_implementation_unittest.cc
index ee06435191d9328418bab17db9886a5b99322b6b..6ae4c7c115f760b69538aa1d66a105895101e4ee 100644
--- a/gpu/command_buffer/client/gles2_implementation_unittest.cc
+++ b/gpu/command_buffer/client/gles2_implementation_unittest.cc
@@ -2680,8 +2680,8 @@ TEST_F(GLES3ImplementationTest, SubImage3DUnpack) {
static const GLint kSrcHeight = 7;
static const GLint kSrcSubImageX0 = 11;
static const GLint kSrcSubImageX1 = 16;
- static const GLint kSrcSubImageY0 = 20;
- static const GLint kSrcSubImageY1 = 23;
+ static const GLint kSrcSubImageY0 = 1;
+ static const GLint kSrcSubImageY1 = 4;
static const GLint kSrcSubImageZ0 = 2;
static const GLint kSrcSubImageZ1 = 5;
static const GLint kSrcSubImageWidth = kSrcSubImageX1 - kSrcSubImageX0;
@@ -2712,7 +2712,7 @@ TEST_F(GLES3ImplementationTest, SubImage3DUnpack) {
// Makes sure the pixels size is large enough for all tests.
pixel_params.alignment = 8;
ASSERT_TRUE(GLES2Util::ComputeImageDataSizesES3(
- kSrcWidth, kSrcSubImageY1, kSrcSubImageZ1, kFormat, kType,
+ kSrcWidth, kSrcHeight, kSrcSubImageZ1, kFormat, kType,
pixel_params, &pixel_size, nullptr, nullptr, nullptr, nullptr));
std::unique_ptr<uint8_t[]> src_pixels;
src_pixels.reset(new uint8_t[pixel_size]);
« no previous file with comments | « gpu/command_buffer/client/gles2_implementation.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698