third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp - Issue 2154143005: Calculate correct cull rect for SVG inline text boxes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp

Issue 2154143005: Calculate correct cull rect for SVG inline text boxes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use outsets. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/DOMSelection.h ('k') | third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainterTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp b/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp

index 71497f19b4e7d726b137fc59243de4674977f0d5..0f588d7151fa36e4b4dbf9ae893fa8142aa0eb11 100644

--- a/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp

@@ -45,13 +45,12 @@ FloatRect SVGInlineTextBoxPainter::boundsForDrawingRecorder(

// computation in SVGInlineTextBox::calculateBoundaries, and the fact that vertical (etc)

// layouts are handled by SVGTextLayoutEngine.

LayoutRect bounds(

- m_svgInlineTextBox.topLeft(),

+ LayoutPoint(m_svgInlineTextBox.topLeft() + paintOffset),

LayoutSize(m_svgInlineTextBox.logicalWidth(), m_svgInlineTextBox.logicalHeight()));

if (includeSelectionRect) {

bounds.unite(m_svgInlineTextBox.localSelectionRect(

m_svgInlineTextBox.start(), m_svgInlineTextBox.start() + m_svgInlineTextBox.len()));

}

- bounds.moveBy(paintOffset);

return FloatRect(bounds);

}