Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.h

Issue 2153943002: Implementing TabManager extensions API Discard Function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: testcases Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/tabs/tabs_api.h
diff --git a/chrome/browser/extensions/api/tabs/tabs_api.h b/chrome/browser/extensions/api/tabs/tabs_api.h
index 7457aad43d8c735c3904923a207cb3b18ffbee07..07b8df8fe1c6ae61ad98462c363793ddca0ebc0d 100644
--- a/chrome/browser/extensions/api/tabs/tabs_api.h
+++ b/chrome/browser/extensions/api/tabs/tabs_api.h
@@ -136,7 +136,7 @@ class TabsHighlightFunction : public ChromeSyncExtensionFunction {
bool RunSync() override;
bool HighlightTab(TabStripModel* tabstrip,
ui::ListSelectionModel* selection,
- int *active_index,
+ int* active_index,
int index);
DECLARE_EXTENSION_FUNCTION("tabs.highlight", TABS_HIGHLIGHT)
};
@@ -322,6 +322,14 @@ class TabsGetZoomSettingsFunction : public ZoomAPIFunction {
DECLARE_EXTENSION_FUNCTION("tabs.getZoomSettings", TABS_GETZOOMSETTINGS)
};
+class TabsDiscardFunction : public ChromeSyncExtensionFunction {
+ ~TabsDiscardFunction() override {}
Georges Khalil 2016/07/19 19:39:45 missing private.
Anderson Silva 2016/07/19 20:28:42 Hmm. I think private is not necessary. Most of the
Georges Khalil 2016/07/19 20:35:40 Yeah, it seems to be inconsistent through out the
+
+ bool RunSync() override;
+
+ DECLARE_EXTENSION_FUNCTION("tabs.discard", TABS_DISCARD)
+};
+
} // namespace extensions
#endif // CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_API_H_
« no previous file with comments | « no previous file | chrome/browser/extensions/api/tabs/tabs_api.cc » ('j') | chrome/browser/extensions/api/tabs/tabs_api.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698