Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: chrome/browser/extensions/api/tabs/tabs_api.h

Issue 2153943002: Implementing TabManager extensions API Discard Function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: testcases Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_API_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_API_H_
6 #define CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_API_H_ 6 #define CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_API_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 class TabsDuplicateFunction : public ChromeSyncExtensionFunction { 129 class TabsDuplicateFunction : public ChromeSyncExtensionFunction {
130 ~TabsDuplicateFunction() override {} 130 ~TabsDuplicateFunction() override {}
131 bool RunSync() override; 131 bool RunSync() override;
132 DECLARE_EXTENSION_FUNCTION("tabs.duplicate", TABS_DUPLICATE) 132 DECLARE_EXTENSION_FUNCTION("tabs.duplicate", TABS_DUPLICATE)
133 }; 133 };
134 class TabsHighlightFunction : public ChromeSyncExtensionFunction { 134 class TabsHighlightFunction : public ChromeSyncExtensionFunction {
135 ~TabsHighlightFunction() override {} 135 ~TabsHighlightFunction() override {}
136 bool RunSync() override; 136 bool RunSync() override;
137 bool HighlightTab(TabStripModel* tabstrip, 137 bool HighlightTab(TabStripModel* tabstrip,
138 ui::ListSelectionModel* selection, 138 ui::ListSelectionModel* selection,
139 int *active_index, 139 int* active_index,
140 int index); 140 int index);
141 DECLARE_EXTENSION_FUNCTION("tabs.highlight", TABS_HIGHLIGHT) 141 DECLARE_EXTENSION_FUNCTION("tabs.highlight", TABS_HIGHLIGHT)
142 }; 142 };
143 class TabsUpdateFunction : public ChromeAsyncExtensionFunction { 143 class TabsUpdateFunction : public ChromeAsyncExtensionFunction {
144 public: 144 public:
145 TabsUpdateFunction(); 145 TabsUpdateFunction();
146 146
147 protected: 147 protected:
148 ~TabsUpdateFunction() override {} 148 ~TabsUpdateFunction() override {}
149 virtual bool UpdateURL(const std::string& url, 149 virtual bool UpdateURL(const std::string& url,
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
315 315
316 class TabsGetZoomSettingsFunction : public ZoomAPIFunction { 316 class TabsGetZoomSettingsFunction : public ZoomAPIFunction {
317 private: 317 private:
318 ~TabsGetZoomSettingsFunction() override {} 318 ~TabsGetZoomSettingsFunction() override {}
319 319
320 bool RunAsync() override; 320 bool RunAsync() override;
321 321
322 DECLARE_EXTENSION_FUNCTION("tabs.getZoomSettings", TABS_GETZOOMSETTINGS) 322 DECLARE_EXTENSION_FUNCTION("tabs.getZoomSettings", TABS_GETZOOMSETTINGS)
323 }; 323 };
324 324
325 class TabsDiscardFunction : public ChromeSyncExtensionFunction {
326 ~TabsDiscardFunction() override {}
Georges Khalil 2016/07/19 19:39:45 missing private.
Anderson Silva 2016/07/19 20:28:42 Hmm. I think private is not necessary. Most of the
Georges Khalil 2016/07/19 20:35:40 Yeah, it seems to be inconsistent through out the
327
328 bool RunSync() override;
329
330 DECLARE_EXTENSION_FUNCTION("tabs.discard", TABS_DISCARD)
331 };
332
325 } // namespace extensions 333 } // namespace extensions
326 334
327 #endif // CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_API_H_ 335 #endif // CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_API_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/api/tabs/tabs_api.cc » ('j') | chrome/browser/extensions/api/tabs/tabs_api.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698