Issue 215373004: Makes mojo WebUI run main only after page finishes loading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 215373004: Makes mojo WebUI run main only after page finishes loading (Closed)

Created:
6 years, 9 months ago by sky

Modified:
6 years, 9 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, creis+watch_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Makes mojo WebUI run main only after page finishes loading This way there isn't possible race conditions if main is run before the page finishes loading. BUG=none TEST=none R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260266

Patch Set 1 #

Patch Set 2 : merge 2 trunk #

Patch Set 3 : rename DidFinishDocumentLoad so it doesn't conflict with RVO #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -9 lines)			Patch
M	content/browser/renderer_host/render_process_host_impl.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_mojo_impl.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/renderer/web_ui_mojo.h	View	1 2	3 chunks	+18 lines, -0 lines	0 comments	Download
M	content/renderer/web_ui_mojo.cc	View	1 2	2 chunks	+24 lines, -5 lines	0 comments	Download
M	content/renderer/web_ui_mojo_context_state.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

6 years, 9 months ago (2014-03-28 20:46:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r260266 (presubmit successful).

Expand Messages | Collapse Messages