Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3702)

Unified Diff: content/renderer/web_ui_mojo.cc

Issue 215373004: Makes mojo WebUI run main only after page finishes loading (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rename DidFinishDocumentLoad so it doesn't conflict with RVO Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/web_ui_mojo.h ('k') | content/renderer/web_ui_mojo_context_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/web_ui_mojo.cc
diff --git a/content/renderer/web_ui_mojo.cc b/content/renderer/web_ui_mojo.cc
index 21d85dacaa867df80c28f236c7732b3006a4ee0b..58f67a85b1f8a05bea8765b447bad967b53fd9ee 100644
--- a/content/renderer/web_ui_mojo.cc
+++ b/content/renderer/web_ui_mojo.cc
@@ -41,18 +41,23 @@ void WebUIMojo::MainFrameObserver::WillReleaseScriptContext(
web_ui_mojo_->DestroyContextState(context);
}
+void WebUIMojo::MainFrameObserver::DidFinishDocumentLoad() {
+ web_ui_mojo_->OnDidFinishDocumentLoad();
+}
+
WebUIMojo::WebUIMojo(RenderView* render_view)
: RenderViewObserver(render_view),
RenderViewObserverTracker<WebUIMojo>(render_view),
- main_frame_observer_(this) {
+ main_frame_observer_(this),
+ did_finish_document_load_(false) {
CreateContextState();
}
void WebUIMojo::SetBrowserHandle(mojo::ScopedMessagePipeHandle handle) {
- v8::HandleScope handle_scope(blink::mainThreadIsolate());
- WebUIMojoContextState* state = GetContextState();
- if (state)
- state->SetHandle(handle.Pass());
+ if (did_finish_document_load_)
+ SetHandleOnContextState(handle.Pass());
+ else
+ pending_handle_ = handle.Pass();
}
WebUIMojo::~WebUIMojo() {
@@ -76,6 +81,20 @@ void WebUIMojo::DestroyContextState(v8::Handle<v8::Context> context) {
context_data->RemoveUserData(kWebUIMojoContextStateKey);
}
+void WebUIMojo::OnDidFinishDocumentLoad() {
+ did_finish_document_load_ = true;
+ if (pending_handle_.is_valid())
+ SetHandleOnContextState(pending_handle_.Pass());
+}
+
+void WebUIMojo::SetHandleOnContextState(mojo::ScopedMessagePipeHandle handle) {
+ DCHECK(did_finish_document_load_);
+ v8::HandleScope handle_scope(blink::mainThreadIsolate());
+ WebUIMojoContextState* state = GetContextState();
+ if (state)
+ state->SetHandle(handle.Pass());
+}
+
WebUIMojoContextState* WebUIMojo::GetContextState() {
blink::WebFrame* frame = render_view()->GetWebView()->mainFrame();
v8::HandleScope handle_scope(blink::mainThreadIsolate());
« no previous file with comments | « content/renderer/web_ui_mojo.h ('k') | content/renderer/web_ui_mojo_context_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698