Added a command line switch to disable xinput2, enabled xinput2 by default

Added a command line switch to disable xinput2, enabled xinput2 by default

I added the switch --disable-high-precision-scrolling to disable xinput2
scrolling functionality. The switch is named high-precision rather than smooth
to avoid confusion with the scroll interpolation feature known as smooth
scrolling.

This CL also re-enables xinput2. I believe that all the bugs that caused it to
be disabled are now fixed (once https://codereview.chromium.org/2077163003/ is
in) but this switch will help mitigation if I am wrong (which I suspect I might
be given the range of prior bugs).

I've added two new files---have I added them in all the correct gyp/GN
locations?

BUG=616308
Committed: https://crrev.com/5d5004de45d12a79de5dcd1a8e217dce3a1dc190
Cr-Commit-Position: refs/heads/master@{#407792}

[Will Shackleton, 2016-07-14 23:35:46]

Description was changed from

==========
Added a command line switch to disable xinput2, enabled xinput2 by default

I added the switch --disable-high-precision-scrolling to disable xinput2
scrolling functionality. The switch is named high-precision rather than smooth
to avoid confusion with the scroll interpolation feature known as smooth
scrolling.

This CL also re-enables xinput2. I believe that all the bugs that caused it to
be disabled are now fixed (once https://codereview.chromium.org/2077163003/ is
in) but this switch will help mitigation if I am wrong (which I suspect I might
be given the range of prior bugs).

I've added two new files---have I added them in all the correct gyp/GN
locations?

BUG=609748
==========

to

==========
Added a command line switch to disable xinput2, enabled xinput2 by default

I added the switch --disable-high-precision-scrolling to disable xinput2
scrolling functionality. The switch is named high-precision rather than smooth
to avoid confusion with the scroll interpolation feature known as smooth
scrolling.

This CL also re-enables xinput2. I believe that all the bugs that caused it to
be disabled are now fixed (once https://codereview.chromium.org/2077163003/ is
in) but this switch will help mitigation if I am wrong (which I suspect I might
be given the range of prior bugs).

I've added two new files---have I added them in all the correct gyp/GN
locations?

BUG=609748
==========

[Will Shackleton, 2016-07-14 23:35:46]

w.shackleton@gmail.com changed reviewers:
+ bokan@chromium.org, sadrul@chromium.org

[Will Shackleton, 2016-07-14 23:41:12]

Description was changed from

==========
Added a command line switch to disable xinput2, enabled xinput2 by default

I added the switch --disable-high-precision-scrolling to disable xinput2
scrolling functionality. The switch is named high-precision rather than smooth
to avoid confusion with the scroll interpolation feature known as smooth
scrolling.

This CL also re-enables xinput2. I believe that all the bugs that caused it to
be disabled are now fixed (once https://codereview.chromium.org/2077163003/ is
in) but this switch will help mitigation if I am wrong (which I suspect I might
be given the range of prior bugs).

I've added two new files---have I added them in all the correct gyp/GN
locations?

BUG=609748
==========

to

==========
Added a command line switch to disable xinput2, enabled xinput2 by default

I added the switch --disable-high-precision-scrolling to disable xinput2
scrolling functionality. The switch is named high-precision rather than smooth
to avoid confusion with the scroll interpolation feature known as smooth
scrolling.

This CL also re-enables xinput2. I believe that all the bugs that caused it to
be disabled are now fixed (once https://codereview.chromium.org/2077163003/ is
in) but this switch will help mitigation if I am wrong (which I suspect I might
be given the range of prior bugs).

I've added two new files---have I added them in all the correct gyp/GN
locations?

BUG=616308
==========

[bokan, 2016-07-19 16:18:12]

Is this ready for review? (you didn't "publish+mail comments" so I didn't get
notified of it)

[Will Shackleton, 2016-07-19 18:58:46]

Yeah it is. I still don't get the semantics of this code review tool..
(I'm away from computer until Tuesday next week)

On Tue, 19 Jul 2016, 17:18 , <bokan@chromium.org> wrote:

> Is this ready for review? (you didn't "publish+mail comments" so I didn't
> get
> notified of it)
>
> https://codereview.chromium.org/2153683002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[bokan, 2016-07-20 13:27:05]

https://codereview.chromium.org/2153683002/diff/1/ui/events/devices/x11/ui_ev...
File ui/events/devices/x11/ui_events_devices_x11_switches.h (right):

https://codereview.chromium.org/2153683002/diff/1/ui/events/devices/x11/ui_ev...
ui/events/devices/x11/ui_events_devices_x11_switches.h:13: extern const char
kDisableHighPrecisionScrolling[];
Adding a file just for this is probably overkill. I would just put this in
ui/events/event_switches.cc

[Will Shackleton, 2016-07-20 15:06:27]

I'm fairly certain I tried that and it caused a circular dependency in the
GN Files. I can confirm if it was this file or not next week!

On Wed, 20 Jul 2016, 14:27 , <bokan@chromium.org> wrote:

>
>
>
https://codereview.chromium.org/2153683002/diff/1/ui/events/devices/x11/ui_ev...
> File ui/events/devices/x11/ui_events_devices_x11_switches.h (right):
>
>
>
https://codereview.chromium.org/2153683002/diff/1/ui/events/devices/x11/ui_ev...
> ui/events/devices/x11/ui_events_devices_x11_switches.h:13: extern const
> char kDisableHighPrecisionScrolling[];
> Adding a file just for this is probably overkill. I would just put this
> in ui/events/event_switches.cc
>
> https://codereview.chromium.org/2153683002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sadrul, 2016-07-20 17:02:26]

On 2016/07/20 15:06:27, Will Shackleton wrote:
> I'm fairly certain I tried that and it caused a circular dependency in the
> GN Files. I can confirm if it was this file or not next week!

Add it where it's used instead (i.e. in device_data_manager_x11.cc)

https://codereview.chromium.org/2153683002/diff/1/ui/events/devices/x11/devic...
File ui/events/devices/x11/device_data_manager_x11.cc (right):

https://codereview.chromium.org/2153683002/diff/1/ui/events/devices/x11/devic...
ui/events/devices/x11/device_data_manager_x11.cc:784: }
no {}

Move after the DCHECK() above

[Will Shackleton, 2016-07-25 20:53:38]

File deleted, flag moved to the anonymous namespace where it is used.

https://codereview.chromium.org/2153683002/diff/1/ui/events/devices/x11/devic...
File ui/events/devices/x11/device_data_manager_x11.cc (right):

https://codereview.chromium.org/2153683002/diff/1/ui/events/devices/x11/devic...
ui/events/devices/x11/device_data_manager_x11.cc:784: }
On 2016/07/20 17:02:26, sadrul wrote:
> no {}
> 
> Move after the DCHECK() above

Done.

[bokan, 2016-07-26 13:40:21]

non-OWNER lgtm

[sadrul, 2016-07-26 13:58:46]

lgtm

[Will Shackleton, 2016-07-26 13:59:15]

The CQ bit was checked by w.shackleton@gmail.com

[commit-bot: I haz the power, 2016-07-26 13:59:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 14:38:46]

Description was changed from

==========
Added a command line switch to disable xinput2, enabled xinput2 by default

I added the switch --disable-high-precision-scrolling to disable xinput2
scrolling functionality. The switch is named high-precision rather than smooth
to avoid confusion with the scroll interpolation feature known as smooth
scrolling.

This CL also re-enables xinput2. I believe that all the bugs that caused it to
be disabled are now fixed (once https://codereview.chromium.org/2077163003/ is
in) but this switch will help mitigation if I am wrong (which I suspect I might
be given the range of prior bugs).

I've added two new files---have I added them in all the correct gyp/GN
locations?

BUG=616308
==========

to

==========
Added a command line switch to disable xinput2, enabled xinput2 by default

I added the switch --disable-high-precision-scrolling to disable xinput2
scrolling functionality. The switch is named high-precision rather than smooth
to avoid confusion with the scroll interpolation feature known as smooth
scrolling.

This CL also re-enables xinput2. I believe that all the bugs that caused it to
be disabled are now fixed (once https://codereview.chromium.org/2077163003/ is
in) but this switch will help mitigation if I am wrong (which I suspect I might
be given the range of prior bugs).

I've added two new files---have I added them in all the correct gyp/GN
locations?

BUG=616308
==========

[commit-bot: I haz the power, 2016-07-26 14:38:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-26 14:40:50]

Description was changed from

==========
Added a command line switch to disable xinput2, enabled xinput2 by default

I added the switch --disable-high-precision-scrolling to disable xinput2
scrolling functionality. The switch is named high-precision rather than smooth
to avoid confusion with the scroll interpolation feature known as smooth
scrolling.

This CL also re-enables xinput2. I believe that all the bugs that caused it to
be disabled are now fixed (once https://codereview.chromium.org/2077163003/ is
in) but this switch will help mitigation if I am wrong (which I suspect I might
be given the range of prior bugs).

I've added two new files---have I added them in all the correct gyp/GN
locations?

BUG=616308
==========

to

==========
Added a command line switch to disable xinput2, enabled xinput2 by default

I added the switch --disable-high-precision-scrolling to disable xinput2
scrolling functionality. The switch is named high-precision rather than smooth
to avoid confusion with the scroll interpolation feature known as smooth
scrolling.

This CL also re-enables xinput2. I believe that all the bugs that caused it to
be disabled are now fixed (once https://codereview.chromium.org/2077163003/ is
in) but this switch will help mitigation if I am wrong (which I suspect I might
be given the range of prior bugs).

I've added two new files---have I added them in all the correct gyp/GN
locations?

BUG=616308

Committed: https://crrev.com/5d5004de45d12a79de5dcd1a8e217dce3a1dc190
Cr-Commit-Position: refs/heads/master@{#407792}
==========

[commit-bot: I haz the power, 2016-07-26 14:40:51]

Patchset 2 (id:??) landed as
https://crrev.com/5d5004de45d12a79de5dcd1a8e217dce3a1dc190
Cr-Commit-Position: refs/heads/master@{#407792}