Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2153643003: Change ShapeResultShaping::computeSpacing to use TextRun::operator[] (Closed)

Created:
4 years, 5 months ago by kojii
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Change ShapeResultShaping::computeSpacing to use TextRun::operator[] ShapeResultShaping::computeSpacing used to use raw pointer to character buffer in TextRun. This patch changes it to use TextRun::operator[] so that it can rely on the range-check built into TextRun. BUG=621843 Review-Url: https://codereview.chromium.org/2090503002 Cr-Commit-Position: refs/heads/master@{#401250} (cherry picked from commit b18b753c893ad73fea5bd40046b7f55d1247fd10) Committed: https://chromium.googlesource.com/chromium/src/+/2ed54182b9b0e31c3aab524f7f270f7cdcf2d8a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -74 lines) Patch
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResultSpacing.h View 2 chunks +1 line, -71 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResultSpacing.cpp View 1 chunk +54 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kojii
4 years, 5 months ago (2016-07-15 16:15:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2ed54182b9b0e31c3aab524f7f270f7cdcf2d8a5.

Powered by Google App Engine
This is Rietveld 408576698