Change ShapeResultShaping::computeSpacing to use TextRun::operator[]

Change ShapeResultShaping::computeSpacing to use TextRun::operator[]

ShapeResultShaping::computeSpacing used to use raw pointer to character
buffer in TextRun. This patch changes it to use TextRun::operator[] so
that it can rely on the range-check built into TextRun.

BUG=621843
Committed: https://crrev.com/b18b753c893ad73fea5bd40046b7f55d1247fd10
Cr-Commit-Position: refs/heads/master@{#401250}

[kojii, 2016-06-22 07:08:16]

Description was changed from

==========
spacing

BUG=
==========

to

==========
Change ShapeResultShaping::computeSpacing to use TextRun::operator[]

ShapeResultShaping::computeSpacing used to use raw pointer to character
buffer in TextRun. This patch changes it to use TextRun::operator[] so
that it can rely on built-in range-check.

BUG=621843
==========

[kojii, 2016-06-22 07:11:24]

Description was changed from

==========
Change ShapeResultShaping::computeSpacing to use TextRun::operator[]

ShapeResultShaping::computeSpacing used to use raw pointer to character
buffer in TextRun. This patch changes it to use TextRun::operator[] so
that it can rely on built-in range-check.

BUG=621843
==========

to

==========
Change ShapeResultShaping::computeSpacing to use TextRun::operator[]

ShapeResultShaping::computeSpacing used to use raw pointer to character
buffer in TextRun. This patch changes it to use TextRun::operator[] so
that it can rely on the range-check built into TextRun.

BUG=621843
==========

[kojii, 2016-06-22 07:11:42]

kojii@chromium.org changed reviewers:
+ drott@chromium.org, eae@chromium.org

[kojii, 2016-06-22 07:11:42]

PTAL.

[eae, 2016-06-22 10:52:47]

LGTM. OK. This might have performance implications, let's keep an eye on the
graphs.

[kojii, 2016-06-22 11:02:31]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2016-06-22 11:02:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2090503002/1

[kojii, 2016-06-22 11:04:10]

On 2016/06/22 at 10:52:47, eae wrote:
> This might have performance implications, let's keep an eye on the graphs.

Thanks, yeah, I thought of that, but recent experiences tell me that optimizers
do quite a good job on is8Bit, and this is only when spacing exists.

If degraded, I'll bring back template with additional
ASSERT_WITH_SECURITY_IMPLICATIONS.

[eae, 2016-06-22 11:05:04]

Sounds good, thanks kojii!

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2016-06-22 11:06:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-22 11:08:02]

Description was changed from

==========
Change ShapeResultShaping::computeSpacing to use TextRun::operator[]

ShapeResultShaping::computeSpacing used to use raw pointer to character
buffer in TextRun. This patch changes it to use TextRun::operator[] so
that it can rely on the range-check built into TextRun.

BUG=621843
==========

to

==========
Change ShapeResultShaping::computeSpacing to use TextRun::operator[]

ShapeResultShaping::computeSpacing used to use raw pointer to character
buffer in TextRun. This patch changes it to use TextRun::operator[] so
that it can rely on the range-check built into TextRun.

BUG=621843

Committed: https://crrev.com/b18b753c893ad73fea5bd40046b7f55d1247fd10
Cr-Commit-Position: refs/heads/master@{#401250}
==========

[commit-bot: I haz the power, 2016-06-22 11:08:03]

Patchset 1 (id:??) landed as
https://crrev.com/b18b753c893ad73fea5bd40046b7f55d1247fd10
Cr-Commit-Position: refs/heads/master@{#401250}

[eae, 2016-06-22 11:12:59]

Sounds good, thanks kojii!

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.