Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2153503005: exo: Implement support for zwp_stylus_v1 protocol (Closed)

Created:
4 years, 5 months ago by denniskempin
Modified:
4 years, 4 months ago
Reviewers:
reveman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@protocol
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Implement support for zwp_stylus_v1 protocol This CL foward pointer tool, force and tilt information through the zwp_stylus_v1 protocol in wayland. BUG=628332 Committed: https://crrev.com/d2d5264c4fd4114d44d27d00f46963ab65a73527 Cr-Commit-Position: refs/heads/master@{#408468}

Patch Set 1 #

Patch Set 2 : fixed nits and cleanup #

Total comments: 6

Patch Set 3 : fixed nits. #

Patch Set 4 : fixed compile issues for non-chromeos build #

Patch Set 5 : 2nd try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -8 lines) Patch
M components/exo/pointer.h View 4 chunks +16 lines, -0 lines 0 comments Download
M components/exo/pointer.cc View 5 chunks +52 lines, -8 lines 0 comments Download
A components/exo/pointer_stylus_delegate.h View 1 chunk +45 lines, -0 lines 0 comments Download
M components/exo/wayland/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/exo/wayland/server.cc View 1 2 3 4 4 chunks +79 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 26 (14 generated)
denniskempin
PTAL!
4 years, 4 months ago (2016-07-27 00:09:05 UTC) #2
reveman
lgtm, just a quick question and some minor nits https://codereview.chromium.org/2153503005/diff/20001/components/exo/pointer.cc File components/exo/pointer.cc (right): https://codereview.chromium.org/2153503005/diff/20001/components/exo/pointer.cc#newcode196 components/exo/pointer.cc:196: ...
4 years, 4 months ago (2016-07-28 04:01:45 UTC) #3
denniskempin
https://codereview.chromium.org/2153503005/diff/20001/components/exo/pointer.cc File components/exo/pointer.cc (right): https://codereview.chromium.org/2153503005/diff/20001/components/exo/pointer.cc#newcode196 components/exo/pointer.cc:196: constexpr float kEpsilon = std::numeric_limits<float>::epsilon(); On 2016/07/28 04:01:45, reveman ...
4 years, 4 months ago (2016-07-28 17:17:40 UTC) #4
denniskempin
did a final end to end test and verified functionality.
4 years, 4 months ago (2016-07-28 17:30:23 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 2144283003 Patch 80001). Please resolve the dependency and ...
4 years, 4 months ago (2016-07-28 17:30:49 UTC) #9
commit-bot: I haz the power
This CL has an open dependency (Issue 2144283003 Patch 80001). Please resolve the dependency and ...
4 years, 4 months ago (2016-07-28 17:32:39 UTC) #12
denniskempin
okay, gotta wait for the dependency to go through the CQ first, it won't pick ...
4 years, 4 months ago (2016-07-28 17:33:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153503005/40001
4 years, 4 months ago (2016-07-28 18:25:08 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/238161)
4 years, 4 months ago (2016-07-28 18:35:18 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153503005/80001
4 years, 4 months ago (2016-07-28 19:38:56 UTC) #23
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-07-28 20:40:14 UTC) #24
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 20:41:54 UTC) #26
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/d2d5264c4fd4114d44d27d00f46963ab65a73527
Cr-Commit-Position: refs/heads/master@{#408468}

Powered by Google App Engine
This is Rietveld 408576698