wayland-protocols: Add protocol for stylus support

wayland-protocols: Add protocol for stylus support

Extends the wl_pointer protocol to pass along information about
stylus force, tilt and tool type.

BUG=628332
Committed: https://crrev.com/d42d6f314d1358a6b3e671758e9d082cbf54e9d0
Cr-Commit-Position: refs/heads/master@{#408437}

[reveman, 2016-07-14 19:11:04]

reveman@chromium.org changed reviewers:
+ reveman@chromium.org

[reveman, 2016-07-14 19:11:06]

https://codereview.chromium.org/2144283003/diff/20001/third_party/wayland-pro...
File third_party/wayland-protocols/unstable/stylus/README (right):

https://codereview.chromium.org/2144283003/diff/20001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/stylus/README:1: Extension of pointer
protocol with details for on-screen stylus
nit: blank line after this

https://codereview.chromium.org/2144283003/diff/20001/third_party/wayland-pro...
File third_party/wayland-protocols/unstable/stylus/stylus-unstable-v1.xml
(right):

https://codereview.chromium.org/2144283003/diff/20001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/stylus/stylus-unstable-v1.xml:75: <event
name="tool_change">
what happens if any of these properties change while the focus it not on a
client owned surface? are these events sent when pointer enters a new surface
just like button events are?

https://codereview.chromium.org/2144283003/diff/20001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/stylus/stylus-unstable-v1.xml:99:
Notification of a change in tilt of the pointing otol.
s/otol/tool/

[denniskempin, 2016-07-14 20:01:07]

all done. PTAL!

https://codereview.chromium.org/2144283003/diff/20001/third_party/wayland-pro...
File third_party/wayland-protocols/unstable/stylus/README (right):

https://codereview.chromium.org/2144283003/diff/20001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/stylus/README:1: Extension of pointer
protocol with details for on-screen stylus
On 2016/07/14 19:11:06, reveman wrote:
> nit: blank line after this

Done.

https://codereview.chromium.org/2144283003/diff/20001/third_party/wayland-pro...
File third_party/wayland-protocols/unstable/stylus/stylus-unstable-v1.xml
(right):

https://codereview.chromium.org/2144283003/diff/20001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/stylus/stylus-unstable-v1.xml:75: <event
name="tool_change">
On 2016/07/14 19:11:06, reveman wrote:
> what happens if any of these properties change while the focus it not on a
> client owned surface? are these events sent when pointer enters a new surface
> just like button events are?
I updated the doc. We sent the tool type upon enter.

https://codereview.chromium.org/2144283003/diff/20001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/stylus/stylus-unstable-v1.xml:99:
Notification of a change in tilt of the pointing otol.
On 2016/07/14 19:11:06, reveman wrote:
> s/otol/tool/

Done.

[reveman, 2016-07-14 20:06:09]

lgtm % maybe add a similar comment to other events

https://codereview.chromium.org/2144283003/diff/20001/third_party/wayland-pro...
File third_party/wayland-protocols/unstable/stylus/stylus-unstable-v1.xml
(right):

https://codereview.chromium.org/2144283003/diff/20001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/stylus/stylus-unstable-v1.xml:75: <event
name="tool_change">
On 2016/07/14 at 20:01:07, denniskempin wrote:
> On 2016/07/14 19:11:06, reveman wrote:
> > what happens if any of these properties change while the focus it not on a
> > client owned surface? are these events sent when pointer enters a new
surface
> > just like button events are?
> I updated the doc. We sent the tool type upon enter.

Thanks. Sounds good.

https://codereview.chromium.org/2144283003/diff/40001/third_party/wayland-pro...
File third_party/wayland-protocols/unstable/stylus/stylus-unstable-v1.xml
(right):

https://codereview.chromium.org/2144283003/diff/40001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/stylus/stylus-unstable-v1.xml:79: a tool
type other than mouse, this event will also be generated.
I assume this also applies to force/tilt events? Maybe worth having a similar
comment in the description of those events..

[denniskempin, 2016-07-14 20:18:56]

I'll wait with submitting until I got a working implementation. Just in case we
need additions or changes to the protocol.

https://codereview.chromium.org/2144283003/diff/40001/third_party/wayland-pro...
File third_party/wayland-protocols/unstable/stylus/stylus-unstable-v1.xml
(right):

https://codereview.chromium.org/2144283003/diff/40001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/stylus/stylus-unstable-v1.xml:79: a tool
type other than mouse, this event will also be generated.
On 2016/07/14 20:06:09, reveman wrote:
> I assume this also applies to force/tilt events? Maybe worth having a similar
> comment in the description of those events..

Done.

[denniskempin, 2016-07-28 17:32:05]

The CQ bit was checked by denniskempin@google.com

[denniskempin, 2016-07-28 17:32:05]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2144283003/#ps80001
(title: "git checkout stylus")

[commit-bot: I haz the power, 2016-07-28 17:32:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 18:21:34]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-28 18:23:45]

Description was changed from

==========
wayland-protocols: Add protocol for stylus support

Extends the wl_pointer protocol to pass along information about
stylus force, tilt and tool type.

BUG=628332
==========

to

==========
wayland-protocols: Add protocol for stylus support

Extends the wl_pointer protocol to pass along information about
stylus force, tilt and tool type.

BUG=628332

Committed: https://crrev.com/d42d6f314d1358a6b3e671758e9d082cbf54e9d0
Cr-Commit-Position: refs/heads/master@{#408437}
==========

[commit-bot: I haz the power, 2016-07-28 18:23:47]

Patchset 5 (id:??) landed as
https://crrev.com/d42d6f314d1358a6b3e671758e9d082cbf54e9d0
Cr-Commit-Position: refs/heads/master@{#408437}