Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Issue 2153463002: Fixes for ContextBuilder and tests to make them pass on Windows. (Closed)

Created:
4 years, 5 months ago by scheglov
Modified:
4 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixes for ContextBuilder and tests to make them pass on Windows. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/454f9edddd5e73ae0f8abf25ade83c363a9509ba

Patch Set 1 #

Patch Set 2 : Update status file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -18 lines) Patch
M pkg/analyzer/lib/src/context/builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/context/builder_test.dart View 9 chunks +22 lines, -15 lines 0 comments Download
M pkg/pkg.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 5 months ago (2016-07-14 17:51:35 UTC) #1
Brian Wilkerson
lgtm
4 years, 5 months ago (2016-07-14 18:02:01 UTC) #2
scheglov
4 years, 5 months ago (2016-07-14 18:09:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
454f9edddd5e73ae0f8abf25ade83c363a9509ba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698