Fixes for ContextBuilder and tests to make them pass on Windows.

pkg/analyzer/test/src/context/builder_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.test.src.context.context_builder_test;
 
 import 'dart:io' as io;
 
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/file_system/memory_file_system.dart';
@@ skipping 216 matching lines @@
       String rootPath = tempDir.path;
       String projectPath = pathContext.join(rootPath, 'project');
       String packageFilePath = pathContext.join(projectPath, '.packages');
       String packageA = pathContext.join(rootPath, 'pkgs', 'a');
       String embedderPath = pathContext.join(packageA, '_embedder.yaml');
       String packageB = pathContext.join(rootPath, 'pkgs', 'b');
       String extensionPath = pathContext.join(packageB, '_sdkext');
       createFile(
           packageFilePath,
           '''
-a:$packageA
-b:$packageB
+a:${pathContext.toUri(packageA)}
+b:${pathContext.toUri(packageB)}
 ''');
       String asyncPath = pathContext.join(packageA, 'sdk', 'async.dart');
       String corePath = pathContext.join(packageA, 'sdk', 'core.dart');
       createFile(
           embedderPath,
           '''
 embedded_libs:
-  "dart:async": ${pathContext.relative(asyncPath, from: packageA)}
-  "dart:core": ${pathContext.relative(corePath, from: packageA)}
+  "dart:async": ${_relativeUri(asyncPath, from: packageA)}
+  "dart:core": ${_relativeUri(corePath, from: packageA)}
 ''');
       String fooPath = pathContext.join(packageB, 'ext', 'foo.dart');
       createFile(
           extensionPath,
           '''{
-"dart:foo": "${pathContext.relative(fooPath, from: packageB)}"
+"dart:foo": "${_relativeUri(fooPath, from: packageB)}"
 }''');
       AnalysisOptionsImpl options = new AnalysisOptionsImpl();
 
       SourceFactory factory = builder.createSourceFactory(projectPath, options);
 
       Source asyncSource = factory.forUri('dart:async');
       expect(asyncSource, isNotNull);
       expect(asyncSource.fullName, asyncPath);
 
       Source fooSource = factory.forUri('dart:foo');
       expect(fooSource, isNotNull);
       expect(fooSource.fullName, fooPath);
 
       Source packageSource = factory.forUri('package:b/b.dart');
       expect(packageSource, isNotNull);
-      expect(packageSource.fullName, '$packageB/b.dart');
+      expect(packageSource.fullName, pathContext.join(packageB, 'b.dart'));
     });
   }
 
   void test_createSourceFactory_noProvider_packages_embedder_noExtensions() {
     withTempDir((io.Directory tempDir) {
       createDefaultSdk(tempDir);
       String rootPath = tempDir.path;
       String projectPath = pathContext.join(rootPath, 'project');
       String packageFilePath = pathContext.join(projectPath, '.packages');
       String packageA = pathContext.join(rootPath, 'pkgs', 'a');
       String embedderPath = pathContext.join(packageA, '_embedder.yaml');
       String packageB = pathContext.join(rootPath, 'pkgs', 'b');
       createFile(
           packageFilePath,
           '''
-a:$packageA
-b:$packageB
+a:${pathContext.toUri(packageA)}
+b:${pathContext.toUri(packageB)}
 ''');
       String asyncPath = pathContext.join(packageA, 'sdk', 'async.dart');
       String corePath = pathContext.join(packageA, 'sdk', 'core.dart');
       createFile(
           embedderPath,
           '''
 embedded_libs:
-  "dart:async": ${pathContext.relative(asyncPath, from: packageA)}
-  "dart:core": ${pathContext.relative(corePath, from: packageA)}
+  "dart:async": ${_relativeUri(asyncPath, from: packageA)}
+  "dart:core": ${_relativeUri(corePath, from: packageA)}
 ''');
       AnalysisOptionsImpl options = new AnalysisOptionsImpl();
 
       SourceFactory factory = builder.createSourceFactory(projectPath, options);
 
       Source dartSource = factory.forUri('dart:async');
       expect(dartSource, isNotNull);
       expect(dartSource.fullName, asyncPath);
 
       Source packageSource = factory.forUri('package:b/b.dart');
       expect(packageSource, isNotNull);
-      expect(packageSource.fullName, '$packageB/b.dart');
+      expect(packageSource.fullName, pathContext.join(packageB, 'b.dart'));
     });
   }
 
   @failingTest
   void test_createSourceFactory_noProvider_packages_noEmbedder_extensions() {
     fail('Incomplete test');
   }
 
   void test_createSourceFactory_noProvider_packages_noEmbedder_noExtensions() {
     withTempDir((io.Directory tempDir) {
       createDefaultSdk(tempDir);
       String rootPath = tempDir.path;
       String projectPath = pathContext.join(rootPath, 'project');
       String packageFilePath = pathContext.join(projectPath, '.packages');
+      String packageA = pathContext.join(rootPath, 'pkgs', 'a');
+      String packageB = pathContext.join(rootPath, 'pkgs', 'b');
       createFile(
           packageFilePath,
-          r'''
-a:file:///pkgs/a
-b:file:///pkgs/b
+          '''
+a:${pathContext.toUri(packageA)}
+b:${pathContext.toUri(packageB)}
 ''');
       AnalysisOptionsImpl options = new AnalysisOptionsImpl();
 
       SourceFactory factory = builder.createSourceFactory(projectPath, options);
 
       Source dartSource = factory.forUri('dart:core');
       expect(dartSource, isNotNull);
       expect(dartSource.fullName, '$defaultSdkPath/lib/core/core.dart');
 
       Source packageSource = factory.forUri('package:a/a.dart');
       expect(packageSource, isNotNull);
-      expect(packageSource.fullName, '/pkgs/a/a.dart');
+      expect(packageSource.fullName, pathContext.join(packageA, 'a.dart'));
     });
   }
 
   @failingTest
   void test_createSourceFactory_provider() {
     fail('Incomplete test');
   }
 
   /**
    * Execute the [test] function with a temporary [directory]. The test function
    * can perform any disk operations within the directory and the directory (and
    * its content) will be removed after the function returns.
    */
   void withTempDir(test(io.Directory directory)) {
     io.Directory directory =
         io.Directory.systemTemp.createTempSync('analyzer_');
     try {
       test(directory);
     } finally {
       directory.deleteSync(recursive: true);
     }
   }
+
+  Uri _relativeUri(String path, {String from}) {
+    String relativePath = pathContext.relative(path, from: from);
+    return pathContext.toUri(relativePath);
+  }
 }
 
 @reflectiveTest
 class ContextBuilderTest_WithoutDisk extends EngineTestCase {
   /**
    * The resource provider to be used by tests.
    */
   MemoryResourceProvider resourceProvider;
 
   /**
@@ skipping 97 matching lines @@
   void test_getOptionsFile_inRoot_old() {
     String path = '/some/directory/path';
     String filePath = '$path/${AnalysisEngine.ANALYSIS_OPTIONS_FILE}';
     resourceProvider.newFile(filePath, '');
 
     File result = builder.getOptionsFile(path);
     expect(result, isNotNull);
     expect(result.path, filePath);
   }
 }